navigation-ui ProGuard rules were not changed when Navigation moved to AndroidX [147610424]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jan 13, 2020 09:44PM

Component used: Navigation Version used: 2.2.0-rc04

https://issuetracker.google.com/issues/123449431 added ProGuard rules to navigation-ui to ensure that the back button remains functional with minifyEnabled.

However, those rules were written in the Support Library time and jetifier would convert them to the appropriate AndroidX versions when using Navigation 1.X with an AndroidX project:

# setProgress is called via an ObjectAnimator in AbstractAppBarOnDestinationChangedListener
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
    void setProgress(float);
}

Since Navigation moved to 2.X and is now part of AndroidX, Jetifier does not apply any transformations and navigation-ui's ProGuard rules need to be updated to reflect the appropriate AndroidX package name for DrawerArrowDrawable (androidx.appcompat.graphics.drawable.DrawerArrowDrawable).

Comments

jb...@google.com <jb...@google.com> #2Jan 14, 2020 06:39PM

Accepted by jb...@google.com.

Could we get an official response to this feature request? Is there an idea to support SafeArgs in navigation-compose one day? Not asking for any time frames. Maybe there is no plans for statically generated args for navigation-compose at all.

ap...@google.com <ap...@google.com> #3Jan 15, 2020 04:03AM

Please check out my implementation of the same-

Part 1-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-95c84722eec2

Part 2-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-part-2-218a6ae7a027

Github repo-

https://github.com/dilrajsingh1997/safe-compose-args

jb...@google.com <jb...@google.com> #4Jan 15, 2020 05:31PM

Marked as fixed.

Integration guide-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-part-3-2e5ab79b9a05

IssueTracker