navigation-ui ProGuard rules were not changed when Navigation moved to AndroidX [147610424]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jan 13, 2020 09:44PM

Component used: Navigation Version used: 2.2.0-rc04

https://issuetracker.google.com/issues/123449431 added ProGuard rules to navigation-ui to ensure that the back button remains functional with minifyEnabled.

However, those rules were written in the Support Library time and jetifier would convert them to the appropriate AndroidX versions when using Navigation 1.X with an AndroidX project:

# setProgress is called via an ObjectAnimator in AbstractAppBarOnDestinationChangedListener
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
    void setProgress(float);
}

Since Navigation moved to 2.X and is now part of AndroidX, Jetifier does not apply any transformations and navigation-ui's ProGuard rules need to be updated to reflect the appropriate AndroidX package name for DrawerArrowDrawable (androidx.appcompat.graphics.drawable.DrawerArrowDrawable).

Comments

jb...@google.com <jb...@google.com> #2Jan 14, 2020 06:39PM

Accepted by jb...@google.com.

seems to be dup: b/212982460

ap...@google.com <ap...@google.com> #3Jan 15, 2020 04:03AM

Fundamentally the issue here is that the selection logic happening in composition depends on the text layout result which is available on measure. So we end up using stale TextLayoutResult which causes the issue.

jb...@google.com <jb...@google.com> #4Jan 15, 2020 05:31PM

Marked as fixed.

This is the same exception as in b/229378536 and b/221580975 as well, and it also involves selection, so I'm wondering if those two bugs have the same cause Anastasia described.

an...@google.com <an...@google.com> #5Jan 23, 2020 08:41PM

There is a similar problem regarding Magnifier but I don't think these are directly related. The main cause for this issue is the async relation between TextFieldValue and layoutResult. Magnifier related crashes don't seem to be caused by changes in TextFieldValue or layout.

Issue 147610424

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Jan 14, 2020 06:39PM

ap...@google.com <ap...@google.com> #3Jan 15, 2020 04:03AM

jb...@google.com <jb...@google.com> #4Jan 15, 2020 05:31PM

an...@google.com <an...@google.com> #5Jan 23, 2020 08:41PM

Add comment

Issue metadata