Fixed
Status Update
No update yet.
Comments
jb...@google.com
Filling in the data, action, and mimeType fields of the Intent for any usages of NavDeepLinkRequest makes sense to me.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 6ac4bffb0f35827a19f761599bb642dbd98e146a
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 24 12:10:03 2021
Add intent when navigating with NavDeepLinkRequest
When you navigate with a NavDeepLinkRequest, we should also fill an
intent with the data, action, and type with the values from the
NavDeepLinkRequest, and pass that intent in the arguments of the
resulting destination using KEY_DEEP_LINK_INTENT. That way, the info can
be accessed from the resulting destination.
RelNote: "When navigating using a NavDeepLinkRequest, you can now
access the uri, action, and mimetype in the resulting destination by
getting the intent from arguments via KEY_DEEP_LINK_INTENT."
Bug: 181521877
Test: Adjusted tests in NavControllerTest
Change-Id: Ide575ab7123522da7816c1b219f444173dbfab8d
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/1651033
Branch: androidx-main
commit 6ac4bffb0f35827a19f761599bb642dbd98e146a
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 24 12:10:03 2021
Add intent when navigating with NavDeepLinkRequest
When you navigate with a NavDeepLinkRequest, we should also fill an
intent with the data, action, and type with the values from the
NavDeepLinkRequest, and pass that intent in the arguments of the
resulting destination using KEY_DEEP_LINK_INTENT. That way, the info can
be accessed from the resulting destination.
RelNote: "When navigating using a NavDeepLinkRequest, you can now
access the uri, action, and mimetype in the resulting destination by
getting the intent from arguments via KEY_DEEP_LINK_INTENT."
Bug: 181521877
Test: Adjusted tests in NavControllerTest
Change-Id: Ide575ab7123522da7816c1b219f444173dbfab8d
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
jb...@google.com
This has been fixed internally and will be part of the Navigation 2.3.5 release (via 2.4.0-alpha01).
Description
Component used: Navigation Version used: 2.2.0-rc04
However, those rules were written in the Support Library time and jetifier would convert them to the appropriate AndroidX versions when using Navigation 1.X with an AndroidX project:
Since Navigation moved to 2.X and is now part of AndroidX, Jetifier does not apply any transformations and navigation-ui's ProGuard rules need to be updated to reflect the appropriate AndroidX package name for DrawerArrowDrawable (
androidx.appcompat.graphics.drawable.DrawerArrowDrawable).