navigation-ui ProGuard rules were not changed when Navigation moved to AndroidX [147610424]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jan 13, 2020 09:44PM

Component used: Navigation Version used: 2.2.0-rc04

https://issuetracker.google.com/issues/123449431 added ProGuard rules to navigation-ui to ensure that the back button remains functional with minifyEnabled.

However, those rules were written in the Support Library time and jetifier would convert them to the appropriate AndroidX versions when using Navigation 1.X with an AndroidX project:

# setProgress is called via an ObjectAnimator in AbstractAppBarOnDestinationChangedListener
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
    void setProgress(float);
}

Since Navigation moved to 2.X and is now part of AndroidX, Jetifier does not apply any transformations and navigation-ui's ProGuard rules need to be updated to reflect the appropriate AndroidX package name for DrawerArrowDrawable (androidx.appcompat.graphics.drawable.DrawerArrowDrawable).

Comments

jb...@google.com <jb...@google.com> #2Jan 14, 2020 06:39PM

Accepted by jb...@google.com.

since these are in public API (:/) we need to do this in 1.2

ap...@google.com <ap...@google.com> #3Jan 15, 2020 04:03AM

since it is already marked as deprecated, we can probably do it by now.

jb...@google.com <jb...@google.com> #4Jan 15, 2020 05:31PM

Marked as fixed.

Opening diff shortly

an...@google.com <an...@google.com> #5Jan 23, 2020 08:41PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

Issue 147610424

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Jan 14, 2020 06:39PM

ap...@google.com <ap...@google.com> #3Jan 15, 2020 04:03AM

jb...@google.com <jb...@google.com> #4Jan 15, 2020 05:31PM

an...@google.com <an...@google.com> #5Jan 23, 2020 08:41PM

Add comment

Issue metadata