Fixed
Status Update
No update yet.
Comments
su...@google.com
su...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
su...@google.com
kl...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
su...@google.com
Is there any update on this?
gy...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ccc903ffe73241ef16b77f1303469e4908b2aa96
Author: Gyumin Sim <gyumin@google.com>
Date: Tue Aug 17 21:54:37 2021
Don't start MediaSessionService as foreground for ACTION_STOP
Bug: 148011394
Relnote: Fixed ANR when dismissing media notification
Test: Manually tested with integration testapp
Change-Id: Ifdcc20bba122c235cd977a5049ce84cecc2f55b1
M media2/media2-session/src/main/java/androidx/media2/session/MediaNotificationHandler.java
https://android-review.googlesource.com/1797988
Branch: androidx-main
commit ccc903ffe73241ef16b77f1303469e4908b2aa96
Author: Gyumin Sim <gyumin@google.com>
Date: Tue Aug 17 21:54:37 2021
Don't start MediaSessionService as foreground for ACTION_STOP
Bug: 148011394
Relnote: Fixed ANR when dismissing media notification
Test: Manually tested with integration testapp
Change-Id: Ifdcc20bba122c235cd977a5049ce84cecc2f55b1
M media2/media2-session/src/main/java/androidx/media2/session/MediaNotificationHandler.java
Description
When I dismiss the default notification created by MediaNotificationHandler, I get the following ANR:
Context.startForegroundService() did not then call Service.startForeground()
As far as I can tell the problem is that notification is created with a PendingIntent#getForegroundService() for delete intent, so after I dismiss the notification the service is started again as a foreground, but since the command is ACTION_STOP, nothing happens afterwards and we get the ANR.
If I understood correctly, the ACTION_PAUSE is handled correctly, so that its pending intent will start a regular service instead of a foreground one.
MediaNotificationHandler#206
if (Build.VERSION.SDK_INT >= 26 && action != ACTION_PAUSE) {
return PendingIntent.getForegroundService(
mServiceInstance, keyCode /* requestCode */, intent, 0 /* flags */);
} else {
return PendingIntent.getService(
mServiceInstance, keyCode /* requestCode */, intent, 0 /* flags */);
}
So I guess we should do the same for ACTION_STOP.