Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d08b02d8d644e4b6b61896c06ea8570883f9f609
Author: Matvei Malkov <malkov@google.com>
Date: Wed Jan 22 18:23:49 2020
More Box params
This CL adds borders, backgrounds and shapes support to the box, as well as rewriting padding setting.
Currently borderSize will be used as a default padding, as it assumed
as a most common need with the easy escape pass where you can set.
RelNote: Add paddings, border, shape and background param to Box
Also, samples were added.
Bug: 148147281
Test:
Change-Id: I05027a87956b6e4233a6b8992d321633e9fdcdc9
M ui/ui-foundation/api/0.1.0-dev05.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev05.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev05.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/AndroidManifest.xml
A ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/BoxActivity.kt
A ui/ui-foundation/integration-tests/samples/src/main/java/androidx/ui/foundation/samples/BoxSamples.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Box.kt
M ui/ui-unit/api/0.1.0-dev05.txt
M ui/ui-unit/api/current.txt
M ui/ui-unit/api/public_plus_experimental_0.1.0-dev05.txt
M ui/ui-unit/api/public_plus_experimental_current.txt
M ui/ui-unit/api/restricted_0.1.0-dev05.txt
M ui/ui-unit/api/restricted_current.txt
M ui/ui-unit/src/main/java/androidx/ui/unit/Dp.kt
https://android-review.googlesource.com/1215178
Branch: androidx-master-dev
commit d08b02d8d644e4b6b61896c06ea8570883f9f609
Author: Matvei Malkov <malkov@google.com>
Date: Wed Jan 22 18:23:49 2020
More Box params
This CL adds borders, backgrounds and shapes support to the box, as well as rewriting padding setting.
Currently borderSize will be used as a default padding, as it assumed
as a most common need with the easy escape pass where you can set.
RelNote: Add paddings, border, shape and background param to Box
Also, samples were added.
Bug: 148147281
Test:
Change-Id: I05027a87956b6e4233a6b8992d321633e9fdcdc9
M ui/ui-foundation/api/0.1.0-dev05.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev05.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev05.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/AndroidManifest.xml
A ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/BoxActivity.kt
A ui/ui-foundation/integration-tests/samples/src/main/java/androidx/ui/foundation/samples/BoxSamples.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Box.kt
M ui/ui-unit/api/0.1.0-dev05.txt
M ui/ui-unit/api/current.txt
M ui/ui-unit/api/public_plus_experimental_0.1.0-dev05.txt
M ui/ui-unit/api/public_plus_experimental_current.txt
M ui/ui-unit/api/restricted_0.1.0-dev05.txt
M ui/ui-unit/api/restricted_current.txt
M ui/ui-unit/src/main/java/androidx/ui/unit/Dp.kt
ma...@google.com
Also Box is now Column, support all the params needed and have tests, so it's time to close the main bug for now and let development go through defer tickets
Description
As this is kind of fresh start for Container -> Box story, we can break and change API to replace parameters set with more well-thought options without conflicts and ambiguity.
Decided to go with incremental story, by introducing Box first, then seeing how it plays out, fixing whats wrong and only then deprecating Container.