add/replace using reified types cause fragments to be removed by R8 [148181315]

Fixed

Bug

Status Update

No update yet.

Description

my...@gmail.com

created issue #1

Jan 23, 2020 01:49AM

Component used: Fragment
Version used: 1.2.0
Devices/Android versions reproduced on: N/A

Fragment constructor is removed once we use add/replace<MyFragment>(...).

Comments

il...@google.com <il...@google.com> #2Jan 23, 2020 05:27PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

my...@gmail.com <my...@gmail.com> #3Jan 23, 2020 06:02PM

Great! Thanks a lot, I'll look for the live updates soon!

my...@gmail.com <my...@gmail.com> #4Jan 23, 2020 06:03PM

Another smaller sample that does not use NDK:

https://github.com/Mygod/VPNHotspot/commit/09238462d1e6cd0028927719c1f03a78beb0d6cf

il...@google.com <il...@google.com> #5Jan 23, 2020 09:14PM

Assigned to il...@google.com.

Thanks, I was able to reproduce the issue. As a workaround, you can add a @Keep annotation to your Fragment.

il...@google.com <il...@google.com> Jan 23, 2020 10:24PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #6Jan 23, 2020 10:56PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 80d12ddbb5e1d1b9d66b9a444370f78100b6cbda
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 23 14:13:21 2020

Keep the Fragment default constructor if the class is kept

When using the add or replace methods that
take a Fragment Class, we should make sure that
the default constructor is kept.

Test: Ran sample app provided in the bug
BUG: 148181315
Change-Id: Iec72d20b5d7e4a9e703d10876a7ca1b50d83a6b8

M fragment/fragment/build.gradle
A fragment/fragment/proguard-rules.pro

https://android-review.googlesource.com/1216797

il...@google.com <il...@google.com> #7Jan 23, 2020 10:57PM

Marked as fixed.

We've fixed this internally and it'll be available in a Fragment 1.2.1 release.

an...@google.com <an...@google.com> #8Jan 23, 2020 11:06PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/history/all)
Created: 2020-01-23 23:04:45.867260+00:00
Changes: aosp/1216797

[Deleted User] <[Deleted User]> #9Mar 19, 2020 03:03PM

Just wanted to add that clicking on file fragment/fragment/proguard-rules.pro in the comment #6, which is highlighted (like a link) redirect the user to a scam web page.

You should remove those redirects when the tool post the patch details here. I would not expect that clicking (like I did) on a file-patch link as a chance to infect my PC with some malwares.

Thank you.

[Deleted User] <[Deleted User]> #10Mar 19, 2020 03:09PM

This is a security problem. Every link on the page is not a direct link but a google search with redirect, in this particular case there is a registered scam domain with proguard-rules.pr0 (used 0 to prevent link instead of o)

an...@google.com <an...@google.com> #11Mar 24, 2020 12:10AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/history/all)
Created: 2020-03-24 00:08:58.917870+00:00
Changes: aosp/1266484

ap...@google.com <ap...@google.com> #12Mar 24, 2020 04:53AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 41c9e54ce4ab51f95d19a55fa92a56b6bd018c62
Author: Ian Lake <ilake@google.com>
Date: Mon Mar 23 16:07:32 2020

Allow obfuscation of kept Fragments

Fragments that are kept solely by class
can safely be obfuscated.

By switching to keepclasseswithmembers,
only classes with a default constructor
will qualify to be kept. This also allows
shrinking of classes that are constructed
through a custom FragmentFactory.

Test: tested in sample app at

bug 148181315

#comment4
BUG: 151605338
Change-Id: I68ea8779bce80f33f27658cf87a94ccede5376b0

M fragment/fragment/proguard-rules.pro

https://android-review.googlesource.com/1266484