add/replace using reified types cause fragments to be removed by R8 [148181315]

Fixed

Bug

Status Update

No update yet.

Description

my...@gmail.com

created issue #1

Jan 23, 2020 01:49AM

Component used: Fragment
Version used: 1.2.0
Devices/Android versions reproduced on: N/A

Fragment constructor is removed once we use add/replace<MyFragment>(...).

Comments

il...@google.com <il...@google.com> #2Jan 23, 2020 05:27PM

Seems to be a DNS problem with systems that have 'obtain DNS server address automatically'. Changed my system to a manual setting and the browser etc now work. SDK 2.2 didn't seem to mind the auto setting though.

my...@gmail.com <my...@gmail.com> #3Jan 23, 2020 06:02PM

Could you please describe how/where you changed your system to a manual setting?

my...@gmail.com <my...@gmail.com> #4Jan 23, 2020 06:03PM

Based on its date, this issue was originally reported before Android 2.3. Because of the many changes that existed in Android 4.x compared to previous versions, it's very likely that this issue doesn't exist in recent versions of Android like 4.2.2 or newer. Because of the high likelihood that this issue is obsolete, it is getting closed automatically by a script, without a human looking at it in detail. If the issue still exists on a Nexus 4 or Nexus 7 running Android 4.2.2 and is not related to Google applications, please open a new report accordingly.

il...@google.com <il...@google.com> #5Jan 23, 2020 09:14PM

Assigned to il...@google.com.

java.lang.IllegalArgumentException: Unable to locate adb
at com.android.tools.idea.run.editor.DeployTargetPickerDialog.<init>(DeployTargetPickerDialog.java:144)
at com.android.tools.idea.run.editor.ShowChooserTargetProvider.showPrompt(ShowChooserTargetProvider.java:113)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getDeployTarget(AndroidRunConfigurationBase.java:600)
at com.android.tools.idea.run.AndroidRunConfigurationBase.doGetState(AndroidRunConfigurationBase.java:281)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getState(AndroidRunConfigurationBase.java:241)
at com.intellij.execution.runners.ExecutionEnvironment.getState(ExecutionEnvironment.java:158)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:55)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:50)
at com.intellij.execution.ProgramRunnerUtil.executeConfigurationAsync(ProgramRunnerUtil.java:92)
at com.intellij.execution.ProgramRunnerUtil.executeConfiguration(ProgramRunnerUtil.java:41)
at com.intellij.execution.impl.ExecutionManagerImpl.restart(ExecutionManagerImpl.java:93)
at com.intellij.execution.impl.ExecutionManagerImpl.access$300(ExecutionManagerImpl.java:44)
at com.intellij.execution.impl.ExecutionManagerImpl$3.run(ExecutionManagerImpl.java:442)
at com.intellij.util.concurrency.QueueProcessor.runSafely(QueueProcessor.java:232)
at com.intellij.util.Alarm$Request.runSafely(Alarm.java:356)
at com.intellij.util.Alarm$Request.run(Alarm.java:343)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at com.intellij.util.concurrency.SchedulingWrapper$MyScheduledFutureTask.run(SchedulingWrapper.java:228)
at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:315)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:435)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:419)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:403)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
at java.awt.EventQueue.access$500(EventQueue.java:98)
at java.awt.EventQueue$3.run(EventQueue.java:715)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:755)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:704)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:391)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

il...@google.com <il...@google.com> Jan 23, 2020 10:24PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #6Jan 23, 2020 10:56PM

voilà ce qu'on m'affiche lorsque j’exécute mon programme

il...@google.com <il...@google.com> #7Jan 23, 2020 10:57PM

Marked as fixed.

je ne vois pas comment résoudre ce problème. svp aidez moi

an...@google.com <an...@google.com> #8Jan 23, 2020 11:06PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/history/all)
Created: 2020-01-23 23:04:45.867260+00:00
Changes: aosp/1216797

[Deleted User] <[Deleted User]> #9Mar 19, 2020 03:03PM

Just wanted to add that clicking on file fragment/fragment/proguard-rules.pro in the comment #6, which is highlighted (like a link) redirect the user to a scam web page.

You should remove those redirects when the tool post the patch details here. I would not expect that clicking (like I did) on a file-patch link as a chance to infect my PC with some malwares.

Thank you.

[Deleted User] <[Deleted User]> #10Mar 19, 2020 03:09PM

This is a security problem. Every link on the page is not a direct link but a google search with redirect, in this particular case there is a registered scam domain with proguard-rules.pr0 (used 0 to prevent link instead of o)

an...@google.com <an...@google.com> #11Mar 24, 2020 12:10AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/history/all)
Created: 2020-03-24 00:08:58.917870+00:00
Changes: aosp/1266484

ap...@google.com <ap...@google.com> #12Mar 24, 2020 04:53AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 41c9e54ce4ab51f95d19a55fa92a56b6bd018c62
Author: Ian Lake <ilake@google.com>
Date: Mon Mar 23 16:07:32 2020

Allow obfuscation of kept Fragments

Fragments that are kept solely by class
can safely be obfuscated.

By switching to keepclasseswithmembers,
only classes with a default constructor
will qualify to be kept. This also allows
shrinking of classes that are constructed
through a custom FragmentFactory.

Test: tested in sample app at

bug 148181315

#comment4
BUG: 151605338
Change-Id: I68ea8779bce80f33f27658cf87a94ccede5376b0

M fragment/fragment/proguard-rules.pro

https://android-review.googlesource.com/1266484