Android Studio using out of date sources to run tests [148341176]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jan 27, 2020 01:53AM

Recently, Android Studio has been using out of date sources to run tests. It often seems as if it is using sources from one or two runs prior, often complaining about syntax errors that no longer exist.

It also appears as if it is happening to other people as well

https://twitter.com/gpeal8/status/1221499246282567680

I am on 4.0 Canary 8 but others seem to have the issue on Canary 9 as well as 3.6rc1.

If it helps I was encountering this running MvRx tests

https://github.com/airbnb/MvRx/

Comments

ga...@gmail.com <ga...@gmail.com> #2Jan 27, 2020 02:25AM

I am also on Catalina if it helps.

wo...@gmail.com <wo...@gmail.com> #3Jan 27, 2020 06:31AM

I'm also affected but I'm on Windows10. can confirm it on version 4.0 Canary 9

[Deleted User] <[Deleted User]> #4Jan 27, 2020 05:19PM

Happening on junit tests for me as well.

Android Studio 3.6 RC 1
Build #AI-192.7142.36.36.6071332, built on December 13, 2019
Runtime version: 1.8.0_212-release-1586-b4-5784211 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.15.2
GC: ParNew, ConcurrentMarkSweep
Memory: 1237M
Cores: 16
Registry: ide.new.welcome.screen.force=true, ide.tooltip.initialDelay=600
Non-Bundled Plugins: IdeaVIM, org.jetbrains.kotlin, com.squareup.sqldelight

vi...@google.com <vi...@google.com> Jan 28, 2020 09:50AM

Assigned to ar...@google.com.

ar...@google.com <ar...@google.com> #5Jan 28, 2020 09:12PM

I'm not yet able to repro this using MvRx project.
Any additional info any of you have to help us repro this would be useful. Such as:
- Is this happening to Java as well as Kotlin tests?
- How did you start the test run exactly? Through clicking the run button at the top bar, or the run button in the gutter next to the test class/method name, or through context menu in the project view?
- Please attach idea.log of when this reproes for you.

Thanks!

ga...@gmail.com <ga...@gmail.com> #6Jan 28, 2020 10:07PM

1) I ran StateStoreTest by clicking the arrow next to the class name. Tests passed
2) I changed the expected value for the first assert in testSubscribeNotCalledForNoop from 1 to 2
3) I reran the tests with control + r. Tests passed
4) I reran them again and they correctly failed (because I changed the assert)

I also ran YourKit. Out of the last 2 runs, the 2nd to last ran with out of date sources and incorrectly passed. The last run incorrectly failed.

idea.log

1.6 MB

View

Download

studio-2020-01-28-1.snapshot

13 MB

Download

ar...@google.com <ar...@google.com> #7Jan 29, 2020 06:58PM

Thanks, I'm able to repro this now.

ga...@gmail.com <ga...@gmail.com> #8Feb 15, 2020 11:16PM

Any update or workaround here? It's extremely error prone to work when you don't know what version of the source Android Studio is using.

ar...@google.com <ar...@google.com> #9Feb 18, 2020 06:58PM

This seems to be an issue where the Gradle plugin does not see up to date sources, maybe due to VFS freshness. Jerome, anyone in Build team can help take a look?

je...@google.com <je...@google.com> Feb 19, 2020 10:52PM

Reassigned to ga...@google.com.

ga...@google.com <ga...@google.com> #10Feb 21, 2020 12:26AM

The issue seems to be that the IDE is not saving files to disc. After changing assert (expecting it to fail), build output contains:

"> Task :mvrx:compileDebugUnitTestSources UP-TO-DATE"

This means that the file state did not change on disk (AGP&Gradle do not use Intellij VFS).

ga...@google.com <ga...@google.com> #11Feb 21, 2020 02:24AM

Reassigned to ra...@google.com.

The issue is in GradleBuildInvoker.executeTasks(Request) method. Because "request.isWaitForCompletion()" is true and the current thread is not a dispatch thread, we invoke "executor.queueAndWaitForCompletion()" without invoking "myDocumentManager.saveAllDocuments()" first. This means that we do not flush editor state to disc before Gradle is invoked. Consequently, build is using stale files.

Raluca, should we always invoke "myDocumentManager.saveAllDocuments()"?

ra...@google.com <ra...@google.com> #12Feb 21, 2020 02:44AM

I think so, yes. It used to be the case, before Change I3b29b1a3bfc. And also, looking at IntelliJ's own handling of Gradle-based projects (ExternalSystemUtil), their incantation before calling Gradle is:

TransactionGuard.getInstance().assertWriteSafeContext(ModalityState.defaultModalityState());
ApplicationManager.getApplication().invokeAndWait(FileDocumentManager.getInstance()::saveAllDocuments);

ga...@google.com <ga...@google.com> #13Feb 21, 2020 08:26PM

Reassigned to sm...@google.com.

Thanks for confirming that. Bradley can take care of fixing this.

sm...@google.com <sm...@google.com> Mar 5, 2020 10:45PM

Marked as fixed.

ga...@gmail.com <ga...@gmail.com> #14Mar 5, 2020 10:46PM

Thanks for fixing this! Will it be cherry-picked into 4.0?

sm...@google.com <sm...@google.com> #15Mar 5, 2020 11:40PM

Yes, it should be in 4.0 Beta 3. Thanks for the report. Please let me know if you still encounter any issues.

sa...@google.com <sa...@google.com> #16Mar 5, 2020 11:41PM

Yes, it will be in our upcoming 4.0 Beta release likely 4.0 Beta 3.

ga...@gmail.com <ga...@gmail.com> #17Mar 5, 2020 11:47PM

Amazing, thank you!

gr...@gmail.com <gr...@gmail.com> #18Mar 12, 2020 07:45PM

Thank you! What's the status for AndroidStudio 3.6?

sm...@google.com <sm...@google.com> #19Mar 16, 2020 03:45PM

This should be in the next point release (if there is one, 3.6.2).

ms...@vivino.com <ms...@vivino.com> #20Jul 13, 2022 07:57AM

Still actual in latest version of AS

je...@google.com <je...@google.com> #21Jul 13, 2022 01:15PM

#20, can you provide more details with steps and a reproducable test project maybe ?

vi...@gmail.com <vi...@gmail.com> #22Jul 26, 2022 04:56AM

Issue still exists in Android Studio Chipmunk | 2021.2.1 Patch 1

wi...@gmail.com <wi...@gmail.com> #23Aug 3, 2022 07:57AM

Same here.

Android Studio Chipmunk | 2021.2.1 Patch 1
Build #AI-212.5712.43.2112.8609683, built on May 19, 2022
Runtime version: 11.0.12+0-b1504.28-7817840 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.5
GC: G1 Young Generation, G1 Old Generation
Memory: 2560M
Cores: 8
Registry: external.system.auto.import.disabled=true
Non-Bundled Plugins: org.jetbrains.kotlin (212-1.7.10-release-333-AS5457.46)

mr...@gmail.com <mr...@gmail.com> #24Aug 23, 2022 04:42PM

I am with you.

Build: AI-212.5712.43.2112.8609683, 202205181650,

AI-212.5712.43.2112.8609683, JRE 11.0.12+0-b1504.28-7817840x64 JetBrains s.r.o., OS Linux(amd64) v5.15.0-46-generic, screens 2560.0x1440.0

AS: Chipmunk | 2021.2.1 Patch 1; Kotlin plugin: 212-1.7.10-release-333-AS5457.46; Android Gradle Plugin: 7.2.1; Gradle: 7.3.3; Gradle JDK: version 11.0.12; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)Source: send_feedback_icon

sm...@google.com <sm...@google.com> Aug 23, 2022 04:52PM

Status: New

ga...@google.com <ga...@google.com> #25Aug 25, 2022 09:36AM

Marked as fixed, reassigned to ga...@google.com.

Thank you all for recent reports. The root cause of this particular issue is fixed, to reporters in #20, #22, #23, #24, can you please file a new bug with idea.log, repro steps, or any other useful information that will help us debug this?

vv...@gmail.com <vv...@gmail.com> #26Aug 25, 2022 11:39AM

I get the same issue on running junit with coverage

Android Studio Chipmunk | 2021.2.1 Patch 1
Build #AI-212.5712.43.2112.8609683, built on May 18, 2022
Runtime version: 11.0.12+0-b1504.28-7817840 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.4
GC: G1 Young Generation, G1 Old Generation
Memory: 6144M
Cores: 12
Registry: external.system.auto.import.disabled=true
Non-Bundled Plugins: com.robohorse.robopojogenerator (2.3.5), org.jetbrains.kotlin (212-1.7.0-release-281-AS5457.46)

pe...@gmail.com <pe...@gmail.com> #27Sep 5, 2022 04:03PM

Same here.

Cleaning project. Run "Run TestCase with Coverage..." -> Project out of date. Hide coverage or recompile only options to choose between.

Android Studio Chipmunk | 2021.2.1 Patch 2
Build #AI-212.5712.43.2112.8815526, built on July 10, 2022
Runtime version: 11.0.12+0-b1504.28-7817840 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.5.1
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 10
Registry: external.system.auto.import.disabled=true, ide.instant.shutdown=false

ga...@google.com <ga...@google.com> #28Sep 6, 2022 10:06AM

Re #27: You are probably hitting https://issuetracker.google.com/241426924, please follow progress on that issue.