Avoid jetifier skipping mixed androidx / support libraries [148462462]

Fixed

Feature Request

Reviewed (L1)

Status Update

No update yet.

Description

pa...@google.com

created issue #1

Jan 28, 2020 07:39PM

Jetifier has a detection to skip libraries that contain androidX references in their bytecode. However this does not work for libraries that are migrated only partially. As a remedy we need to also look for android.support references and if we find any we rewrite the library (and show a warning). This still makes the detection useful as we don't scan strings. So in case of library with ambiguous or backwards compatibility strings that is depending only on androidx we still skip it.

Comments

ap...@google.com <ap...@google.com> #2Jan 29, 2020 01:06PM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

pa...@google.com <pa...@google.com> #3Jan 30, 2020 12:10PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

ga...@google.com <ga...@google.com> #4Jan 30, 2020 12:21PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

ga...@google.com <ga...@google.com> #5Feb 22, 2020 07:56PM

Assigned to pa...@google.com.

Can we update AGP 4.0 to use this version?

hu...@google.com <hu...@google.com> #6Feb 24, 2020 09:37AM

Yes, I'll send out a CL for that.

hu...@google.com <hu...@google.com> #7Feb 26, 2020 11:35AM

Marked as fixed.

Jetifier 1.0.0-beta09 have been included in AGP 4.0.0-beta02 and 4.1.0-alpha02:

https://android.googlesource.com/platform/tools/base/+/3839282c272e1fe6d93f800ea6c5772ef505f7d8#

[Deleted User] <[Deleted User]> #8Apr 25, 2020 09:20PM

unfortunately, the jetifier still fails for this libraries:

com.facebook.android:facebook-android-sdk:5.0.1
com.github.nikartm:image-support:1.0.5
com.clevertap.android:clevertap-android-sdk:3.7.2

I've also did this: https://github.com/bumptech/glide/issues/3185#issuecomment-619436009 but still no success

My setup: AGP: 4.0.0-beta05 Gradle Wrapper: 6.1.1 Kotlin: 1.3.72

still working on the sample project for to reproduce this

hu...@google.com <hu...@google.com> #9Apr 27, 2020 09:48AM

Can you please attach a stack trace? That'll help confirm if what you're seeing is the same or a different issue.

[Deleted User] <[Deleted User]> #10May 2, 2020 06:26PM

turns out, this fixed my issue for now: https://github.com/facebook/facebook-android-sdk/issues/591#issuecomment-619435280

[Deleted User] <[Deleted User]> #11May 2, 2020 06:27PM

in a clean project this is not hapenned. but with existing codebase migration, there's a lot of 3rd-party library that still using Android Support Library, and the process always fails, my original SO questions: https://stackoverflow.com/questions/61179356/androidx-jetifier-unable-failed-to-transform-3rd-party-transitive-dependency-tha

hu...@google.com <hu...@google.com> #12May 4, 2020 02:00PM

Okay, glad to hear that your issue has been fixed now.

If you run into another Jetifier-related issue, please send us a stack trace of the failure, and we will investigate it. Thanks!