Fixed
Status Update
No update yet.
Comments
[Deleted User] <[Deleted User]>
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
am...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
ki...@google.com
Any particular reason why this has been moved to AppCompat? This is on androidx.security:security-crypto:1.0.0-alpha02
ni...@google.com
[Deleted User] <[Deleted User]>
Any updates on this? I have a PR ready to go.
bo...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 56aa291c97a7a73616b126b9fd996d782504abe5
Author: Nicole Borrelli <borrelli@google.com>
Date: Mon Aug 09 11:26:06 2021
EncryptedFile should throw FileNotFoundException
Changes EncryptedFile#openFileInput() to throw a FileNotFoundException
when the file doesn't exist, rather than a generic IOException.
Bug: 148804719
Test: New + existing tests pass
Relnote: "Changes `EncryptedFile#openFileInput()` to throw
a `FileNotFoundException`, rather than a generic `IOException`
when the requested file doesn't exist."
Change-Id: I80e415bfd53e9e9f3b9a456d50b6b90c0a00c621
A security/security-crypto/api/current.ignore
M security/security-crypto/api/current.txt
M security/security-crypto/api/public_plus_experimental_current.txt
A security/security-crypto/api/restricted_current.ignore
M security/security-crypto/api/restricted_current.txt
M security/security-crypto/src/androidTest/java/androidx/security/crypto/EncryptedFileTest.java
M security/security-crypto/src/main/java/androidx/security/crypto/EncryptedFile.java
https://android-review.googlesource.com/1790155
Branch: androidx-main
commit 56aa291c97a7a73616b126b9fd996d782504abe5
Author: Nicole Borrelli <borrelli@google.com>
Date: Mon Aug 09 11:26:06 2021
EncryptedFile should throw FileNotFoundException
Changes EncryptedFile#openFileInput() to throw a FileNotFoundException
when the file doesn't exist, rather than a generic IOException.
Bug: 148804719
Test: New + existing tests pass
Relnote: "Changes `EncryptedFile#openFileInput()` to throw
a `FileNotFoundException`, rather than a generic `IOException`
when the requested file doesn't exist."
Change-Id: I80e415bfd53e9e9f3b9a456d50b6b90c0a00c621
A security/security-crypto/api/current.ignore
M security/security-crypto/api/current.txt
M security/security-crypto/api/public_plus_experimental_current.txt
A security/security-crypto/api/restricted_current.ignore
M security/security-crypto/api/restricted_current.txt
M security/security-crypto/src/androidTest/java/androidx/security/crypto/EncryptedFileTest.java
M security/security-crypto/src/main/java/androidx/security/crypto/EncryptedFile.java
Description
Version used: 1.0.0-alpha02
Currently EncryptedFile.openFileInput() will throw a generic IOException when the file is missing. This should rather be a FileNotFoundException. The check can actually be removed since FileInputStream will do this for you.