Support Deeplink Uris that have a single query param with no value [148905489]

Fixed

Feature Request

[AOSP] assigned

androidx-bug-bounty

androidx-ui-starter-projects

Status Update

No update yet.

Description

mi...@envoy.com

created issue #1

Feb 5, 2020 07:01PM

Component used: Navigation

Version used: 2.2.0

Devices/Android versions reproduced on:
* Samsung Galaxy Note 10+, Android 9.0
* Google Pixel 4 XL, Android 10

After updating the navigation plugin to 2.2.0, I'm encountering a crash as a result of XML inflation errors from navigation graphs with deeplink schemas. Looking a bit deeper, it seems like this is being caused by a NullPointerException via java.util.regex.Matcher.reset, invoked from androidx.navigation.NavDeepLink.

This is the deep link format that is causing this issue:

<deepLink
android:id="@+id/confirmation_deep_link"
app:uri="envoy://sign-in?{data}" />

This crash does not occur when navigation 2.1.0 is used.

```
2020-02-04 17:43:44.554 2796-2796/com.envoy.app.debug E/AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3594)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2146)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:7770)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1047)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
at java.util.regex.Matcher.reset(Matcher.java:280)
at java.util.regex.Matcher.<init>(Matcher.java:186)
at java.util.regex.Pattern.matcher(Pattern.java:1034)
at androidx.navigation.NavDeepLink.<init>(NavDeepLink.java:69)
at androidx.navigation.NavDestination.addDeepLink(NavDestination.java:355)
at androidx.navigation.NavInflater.inflateDeepLink(NavInflater.java:277)
at androidx.navigation.NavInflater.inflate(NavInflater.java:123)
at androidx.navigation.NavInflater.inflate(NavInflater.java:132)
at androidx.navigation.NavInflater.inflate(NavInflater.java:81)
```

Comments

il...@google.com <il...@google.com> #2Feb 5, 2020 07:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

mi...@envoy.com <mi...@envoy.com> #3Feb 5, 2020 07:19PM

Thanks, I just tested with the new Navigation 2.2.1 update. Sadly, the same crash is still occurring. :(

[Deleted User] <[Deleted User]> #4Feb 5, 2020 07:20PM

Possibly related to

https://issuetracker.google.com/issues/147315928

il...@google.com <il...@google.com> Feb 5, 2020 07:22PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #5Feb 5, 2020 10:27PM

There were indeed changes between 2.1 and 2.2:

Where 2.1 treated query parameters as just another part of the path, 2.2 actually treats query parameters as query parameters so they are now optional and order independent.
As a result, query parameters now require name/value pairs, instead of just names (i.e. data={data}).

If you were to replace the ? in your Uri with / (i.e. envoy://sign-in/{data}), everything would work just fine because Navigation can properly handle path parameters.

That being said, I am going to change this over to a feature request for deeplink to support a single query parameter with no value.
Supporting more than one would be difficult because of the ordering problem:

Given example.com/path?{data1}&{data2} attempting to match with example.com/path?input2&input1, which input should be used for data1?

mi...@envoy.com <mi...@envoy.com> #6Feb 7, 2020 01:51AM

Thanks jb...@google.com!

As per your suggestion, we changed the deep link URI to "envoy://sign-in?data={data}" and are no longer encountering crashes, in addition to deep link working properly.

jb...@google.com <jb...@google.com> Jun 24, 2021 05:16PM

Reassigned to sa...@google.com.

ap...@google.com <ap...@google.com> #7Mar 25, 2022 11:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit d96cc7a1fba9bd7c8431655068fb52eb2fd21afb
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Mar 23 20:15:33 2022

Add support for single query params in NavDeepLink

Adding support for NavDeepLink Uris to have a single
query param with no value

RelNote: "`NavDeepLink` can now parse Uris with a single
query parameter with no value."
Test: deepLinkSingleQueryParamNoValue
Bug: 148905489

Change-Id: I0efe8852542de7d50677499fcd7d32d905163908

M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt

https://android-review.googlesource.com/2038968

sa...@google.com <sa...@google.com> Mar 28, 2022 05:55PM

Marked as fixed.

jb...@google.com <jb...@google.com> #8Mar 28, 2022 07:20PM

This has been added internally and will be available in the Navigation 2.4.2 and 2.5.0-alpha04 releases.