Fixed
Status Update
No update yet.
Comments
il...@google.com
since these are in public API (:/) we need to do this in 1.2
mi...@envoy.com
since it is already marked as deprecated, we can probably do it by now.
[Deleted User] <[Deleted User]>
Opening diff shortly
il...@google.com
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
mi...@envoy.com
Thanks jb...@google.com!
As per your suggestion, we changed the deep link URI to "envoy://sign-in?data={data}" and are no longer encountering crashes, in addition to deep link working properly.
As per your suggestion, we changed the deep link URI to "envoy://sign-in?data={data}" and are no longer encountering crashes, in addition to deep link working properly.
jb...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d96cc7a1fba9bd7c8431655068fb52eb2fd21afb
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Mar 23 20:15:33 2022
Add support for single query params in NavDeepLink
Adding support for NavDeepLink Uris to have a single
query param with no value
RelNote: "`NavDeepLink` can now parse Uris with a single
query parameter with no value."
Test: deepLinkSingleQueryParamNoValue
Bug: 148905489
Change-Id: I0efe8852542de7d50677499fcd7d32d905163908
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
https://android-review.googlesource.com/2038968
Branch: androidx-main
commit d96cc7a1fba9bd7c8431655068fb52eb2fd21afb
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Mar 23 20:15:33 2022
Add support for single query params in NavDeepLink
Adding support for NavDeepLink Uris to have a single
query param with no value
RelNote: "`NavDeepLink` can now parse Uris with a single
query parameter with no value."
Test: deepLinkSingleQueryParamNoValue
Bug: 148905489
Change-Id: I0efe8852542de7d50677499fcd7d32d905163908
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
sa...@google.com
jb...@google.com
This has been added internally and will be available in the Navigation 2.4.2 and 2.5.0-alpha04 releases.
Description
Version used: 2.2.0
Devices/Android versions reproduced on:
* Samsung Galaxy Note 10+, Android 9.0
* Google Pixel 4 XL, Android 10
After updating the navigation plugin to 2.2.0, I'm encountering a crash as a result of XML inflation errors from navigation graphs with deeplink schemas. Looking a bit deeper, it seems like this is being caused by a NullPointerException via java.util.regex.Matcher.reset, invoked from androidx.navigation.NavDeepLink.
This is the deep link format that is causing this issue:
<deepLink
android:id="@+id/confirmation_deep_link"
app:uri="envoy://sign-in?{data}" />
This crash does not occur when navigation 2.1.0 is used.
```
2020-02-04 17:43:44.554 2796-2796/com.envoy.app.debug E/AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3594)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2146)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:7770)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1047)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
at java.util.regex.Matcher.reset(Matcher.java:280)
at java.util.regex.Matcher.<init>(Matcher.java:186)
at java.util.regex.Pattern.matcher(Pattern.java:1034)
at androidx.navigation.NavDeepLink.<init>(NavDeepLink.java:69)
at androidx.navigation.NavDestination.addDeepLink(NavDestination.java:355)
at androidx.navigation.NavInflater.inflateDeepLink(NavInflater.java:277)
at androidx.navigation.NavInflater.inflate(NavInflater.java:123)
at androidx.navigation.NavInflater.inflate(NavInflater.java:132)
at androidx.navigation.NavInflater.inflate(NavInflater.java:81)
```