Support Deeplink Uris that have a single query param with no value [148905489]

Fixed

Feature Request

[AOSP] assigned

androidx-bug-bounty

androidx-ui-starter-projects

Status Update

No update yet.

Description

mi...@envoy.com

created issue #1

Feb 5, 2020 07:01PM

Component used: Navigation

Version used: 2.2.0

Devices/Android versions reproduced on:
* Samsung Galaxy Note 10+, Android 9.0
* Google Pixel 4 XL, Android 10

After updating the navigation plugin to 2.2.0, I'm encountering a crash as a result of XML inflation errors from navigation graphs with deeplink schemas. Looking a bit deeper, it seems like this is being caused by a NullPointerException via java.util.regex.Matcher.reset, invoked from androidx.navigation.NavDeepLink.

This is the deep link format that is causing this issue:

<deepLink
android:id="@+id/confirmation_deep_link"
app:uri="envoy://sign-in?{data}" />

This crash does not occur when navigation 2.1.0 is used.

```
2020-02-04 17:43:44.554 2796-2796/com.envoy.app.debug E/AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3594)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2146)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:7770)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1047)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
at java.util.regex.Matcher.reset(Matcher.java:280)
at java.util.regex.Matcher.<init>(Matcher.java:186)
at java.util.regex.Pattern.matcher(Pattern.java:1034)
at androidx.navigation.NavDeepLink.<init>(NavDeepLink.java:69)
at androidx.navigation.NavDestination.addDeepLink(NavDestination.java:355)
at androidx.navigation.NavInflater.inflateDeepLink(NavInflater.java:277)
at androidx.navigation.NavInflater.inflate(NavInflater.java:123)
at androidx.navigation.NavInflater.inflate(NavInflater.java:132)
at androidx.navigation.NavInflater.inflate(NavInflater.java:81)
```

Comments

il...@google.com <il...@google.com> #2Feb 5, 2020 07:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

mi...@envoy.com <mi...@envoy.com> #3Feb 5, 2020 07:19PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

[Deleted User] <[Deleted User]> #4Feb 5, 2020 07:20PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

il...@google.com <il...@google.com> Feb 5, 2020 07:22PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #5Feb 5, 2020 10:27PM

There were indeed changes between 2.1 and 2.2:

Where 2.1 treated query parameters as just another part of the path, 2.2 actually treats query parameters as query parameters so they are now optional and order independent.
As a result, query parameters now require name/value pairs, instead of just names (i.e. data={data}).

If you were to replace the ? in your Uri with / (i.e. envoy://sign-in/{data}), everything would work just fine because Navigation can properly handle path parameters.

That being said, I am going to change this over to a feature request for deeplink to support a single query parameter with no value.
Supporting more than one would be difficult because of the ordering problem:

Given example.com/path?{data1}&{data2} attempting to match with example.com/path?input2&input1, which input should be used for data1?

mi...@envoy.com <mi...@envoy.com> #6Feb 7, 2020 01:51AM

Thanks jb...@google.com!

As per your suggestion, we changed the deep link URI to "envoy://sign-in?data={data}" and are no longer encountering crashes, in addition to deep link working properly.

jb...@google.com <jb...@google.com> Jun 24, 2021 05:16PM

Reassigned to sa...@google.com.

ap...@google.com <ap...@google.com> #7Mar 25, 2022 11:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit d96cc7a1fba9bd7c8431655068fb52eb2fd21afb
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Mar 23 20:15:33 2022

Add support for single query params in NavDeepLink

Adding support for NavDeepLink Uris to have a single
query param with no value

RelNote: "`NavDeepLink` can now parse Uris with a single
query parameter with no value."
Test: deepLinkSingleQueryParamNoValue
Bug: 148905489

Change-Id: I0efe8852542de7d50677499fcd7d32d905163908

M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt

https://android-review.googlesource.com/2038968

sa...@google.com <sa...@google.com> Mar 28, 2022 05:55PM

Marked as fixed.

jb...@google.com <jb...@google.com> #8Mar 28, 2022 07:20PM

This has been added internally and will be available in the Navigation 2.4.2 and 2.5.0-alpha04 releases.