Support Deeplink Uris that have a single query param with no value [148905489]

Fixed

Feature Request

[AOSP] assigned

androidx-bug-bounty

androidx-ui-starter-projects

Status Update

No update yet.

Description

mi...@envoy.com

created issue #1

Feb 5, 2020 07:01PM

Component used: Navigation

Version used: 2.2.0

Devices/Android versions reproduced on:
* Samsung Galaxy Note 10+, Android 9.0
* Google Pixel 4 XL, Android 10

After updating the navigation plugin to 2.2.0, I'm encountering a crash as a result of XML inflation errors from navigation graphs with deeplink schemas. Looking a bit deeper, it seems like this is being caused by a NullPointerException via java.util.regex.Matcher.reset, invoked from androidx.navigation.NavDeepLink.

This is the deep link format that is causing this issue:

<deepLink
android:id="@+id/confirmation_deep_link"
app:uri="envoy://sign-in?{data}" />

This crash does not occur when navigation 2.1.0 is used.

```
2020-02-04 17:43:44.554 2796-2796/com.envoy.app.debug E/AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3594)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2146)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:7770)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1047)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
at java.util.regex.Matcher.reset(Matcher.java:280)
at java.util.regex.Matcher.<init>(Matcher.java:186)
at java.util.regex.Pattern.matcher(Pattern.java:1034)
at androidx.navigation.NavDeepLink.<init>(NavDeepLink.java:69)
at androidx.navigation.NavDestination.addDeepLink(NavDestination.java:355)
at androidx.navigation.NavInflater.inflateDeepLink(NavInflater.java:277)
at androidx.navigation.NavInflater.inflate(NavInflater.java:123)
at androidx.navigation.NavInflater.inflate(NavInflater.java:132)
at androidx.navigation.NavInflater.inflate(NavInflater.java:81)
```

Comments

il...@google.com <il...@google.com> #2Feb 5, 2020 07:03PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

mi...@envoy.com <mi...@envoy.com> #3Feb 5, 2020 07:19PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

[Deleted User] <[Deleted User]> #4Feb 5, 2020 07:20PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

il...@google.com <il...@google.com> Feb 5, 2020 07:22PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #5Feb 5, 2020 10:27PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

mi...@envoy.com <mi...@envoy.com> #6Feb 7, 2020 01:51AM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

jb...@google.com <jb...@google.com> Jun 24, 2021 05:16PM

Reassigned to sa...@google.com.

ap...@google.com <ap...@google.com> #7Mar 25, 2022 11:12PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

sa...@google.com <sa...@google.com> Mar 28, 2022 05:55PM

Marked as fixed.

jb...@google.com <jb...@google.com> #8Mar 28, 2022 07:20PM

Thank you, I'll try it and check.