Support Deeplink Uris that have a single query param with no value [148905489]

Fixed

Feature Request

[AOSP] assigned

androidx-bug-bounty

androidx-ui-starter-projects

Status Update

No update yet.

Description

mi...@envoy.com

created issue #1

Feb 5, 2020 07:01PM

Component used: Navigation

Version used: 2.2.0

Devices/Android versions reproduced on:
* Samsung Galaxy Note 10+, Android 9.0
* Google Pixel 4 XL, Android 10

After updating the navigation plugin to 2.2.0, I'm encountering a crash as a result of XML inflation errors from navigation graphs with deeplink schemas. Looking a bit deeper, it seems like this is being caused by a NullPointerException via java.util.regex.Matcher.reset, invoked from androidx.navigation.NavDeepLink.

This is the deep link format that is causing this issue:

<deepLink
android:id="@+id/confirmation_deep_link"
app:uri="envoy://sign-in?{data}" />

This crash does not occur when navigation 2.1.0 is used.

```
2020-02-04 17:43:44.554 2796-2796/com.envoy.app.debug E/AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3594)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2146)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:7770)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1047)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
at java.util.regex.Matcher.reset(Matcher.java:280)
at java.util.regex.Matcher.<init>(Matcher.java:186)
at java.util.regex.Pattern.matcher(Pattern.java:1034)
at androidx.navigation.NavDeepLink.<init>(NavDeepLink.java:69)
at androidx.navigation.NavDestination.addDeepLink(NavDestination.java:355)
at androidx.navigation.NavInflater.inflateDeepLink(NavInflater.java:277)
at androidx.navigation.NavInflater.inflate(NavInflater.java:123)
at androidx.navigation.NavInflater.inflate(NavInflater.java:132)
at androidx.navigation.NavInflater.inflate(NavInflater.java:81)
```

Comments

il...@google.com <il...@google.com> #2Feb 5, 2020 07:03PM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

mi...@envoy.com <mi...@envoy.com> #3Feb 5, 2020 07:19PM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

[Deleted User] <[Deleted User]> #4Feb 5, 2020 07:20PM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

il...@google.com <il...@google.com> Feb 5, 2020 07:22PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #5Feb 5, 2020 10:27PM

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

mi...@envoy.com <mi...@envoy.com> #6Feb 7, 2020 01:51AM

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

jb...@google.com <jb...@google.com> Jun 24, 2021 05:16PM

Reassigned to sa...@google.com.

ap...@google.com <ap...@google.com> #7Mar 25, 2022 11:12PM

Added a patch for androidx-master-dev that demos a horizontal ViewPager2 inside a vertical RecyclerView.

Verified that it works correctly on a:
- Nexus 4 emulator with API 17
- Nexus 5X emulator with API 28
- Pixel 2 device with API 29

To reproduce:
- Check out the Android Jetpack source (at commit 256899f482ff85cddfb050f37550be7b5ec927ef) (see steps in [1])
- Apply the patch (`git apply 0001-Add-sample-where-a-horizontal-ViewPager2-is-nested-i.patch`)
- Build and install viewpager2's integration-tests app: `./gradlew viewpager2:integration-tests:testapp:installDebug`
- Run it

Closing the issue for now, but please reopen if you have a minimal reproduction app

[1]

https://android.googlesource.com/platform/frameworks/support/+/256899f482ff85cddfb050f37550be7b5ec927ef

sa...@google.com <sa...@google.com> Mar 28, 2022 05:55PM

Marked as fixed.

jb...@google.com <jb...@google.com> #8Mar 28, 2022 07:20PM

Re-opening as requested by a few users. Narrowed down the focus to nested scrolling elements with the same scroll direction.