Fixed
Status Update
No update yet.
Comments
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/141 .
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
https://android-review.googlesource.com/1649748
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request from
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ae2874e5c9ce8ec478fc54b439df6555cc6edd0e
Author: Ian Lake <ilake@google.com>
Date: Wed Feb 05 13:26:48 2020
Avoid R8 warnings on Fragment ProGuard file
Fragment is a class and therefore the rule should use
'extends' and not 'implements'.
Fixes: 148963981
Test: ran sample project
Change-Id: I004e0dd934ccd1c03e4c1f30bef1e3b267ed346e
M fragment/fragment/proguard-rules.pro
https://android-review.googlesource.com/1227696
Branch: androidx-master-dev
commit ae2874e5c9ce8ec478fc54b439df6555cc6edd0e
Author: Ian Lake <ilake@google.com>
Date: Wed Feb 05 13:26:48 2020
Avoid R8 warnings on Fragment ProGuard file
Fragment is a class and therefore the rule should use
'extends' and not 'implements'.
Fixes: 148963981
Test: ran sample project
Change-Id: I004e0dd934ccd1c03e4c1f30bef1e3b267ed346e
M fragment/fragment/proguard-rules.pro
Description
Component used: Fragment Version used: 1.2.1
When building from the command line, R8 outputs the following warning:
R8: The rule
-neverclassinline public class ** implements androidx.fragment.app.Fragmentuses implements but actually matches extends. R8: The rule-keep public class ** implements androidx.fragment.app.Fragment { public <init>(); }uses implements but actually matches extends.The ProGuard rules should be changed to use
extendsrather thanimplements.