Room bug when fts4 table not set contentEntity [148969394]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Feb 6, 2020 03:33PM

@Entity(tableName = "word_fts")
@Fts4(tokenizer = FtsOptions.TOKENIZER_UNICODE61)
class WorldFts(
var word: String
)

java.lang.IllegalArgumentException: There is no table with name word_fts_content
at androidx.room.InvalidationTracker.addObserver(InvalidationTracker.java:266)
at androidx.room.MultiInstanceInvalidationClient$3.run(MultiInstanceInvalidationClient.java:124)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:764)

It happens when use room Fts4 annotation with enableMultiInstanceInvalidation in room database.

Comments

to...@gmail.com <to...@gmail.com> #2Feb 6, 2020 03:35PM

And here's the minimal working example

https://github.com/Tougee/android-room-with-a-view/tree/kotlin

xm...@gmail.com <xm...@gmail.com> #3Feb 20, 2020 11:42AM

Same problem, when fix ?

da...@google.com <da...@google.com> #4Feb 20, 2020 07:28PM

Sorry for the delay, created a fix for this:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1241328

xm...@gmail.com <xm...@gmail.com> #5Feb 21, 2020 12:23PM

When release?

ap...@google.com <ap...@google.com> #6Feb 21, 2020 04:41PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 302a9bd0131103b3c4b380089bd42788111554ec
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Feb 20 11:24:57 2020

Use tracker lookup table names when creating multi-instance observer.

When creating the multi-instance invalidation tracker observer use the
table lookup keys which correspond to the available table names to
observe and not the names in the internal table names array since those
are mapped to the shadow tables and in the case of an FTS table to a
non-visible table such as Foo_content.

Bug: 148969394
Test: MultiInstanceInvalidationTest
Change-Id: Ief0a906ccd6a87d285035d65f6b4bd87837006f6

M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultiInstanceInvalidationTest.java
A room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Description.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Product.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/ProductDao.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/SampleDatabase.java
M room/runtime/src/main/java/androidx/room/InvalidationTracker.java
M room/runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.java

https://android-review.googlesource.com/1241328

da...@google.com <da...@google.com> #7Feb 21, 2020 05:17PM

Next possible release would be on March. I'll try to set that up.

xm...@gmail.com <xm...@gmail.com> #8Feb 21, 2020 05:37PM

Thank you, we need this. Hope soon...

an...@google.com <an...@google.com> #9Mar 2, 2020 09:36PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/history/all)
Created: 2020-03-02 21:32:38.901846+00:00
Changes: aosp/1241328

to...@gmail.com <to...@gmail.com> #10Mar 5, 2020 07:05AM

Hi, thanks for fix this quickly, but seems there's no room release in March 4, 2020(

https://developer.android.com/jetpack/androidx/versions/all-channel )

da...@google.com <da...@google.com> #11Mar 5, 2020 04:49PM

Room 2.2.5 with this fix will be released by March 18. Sorry but we couldn't get the cherry-pick on time for the March 4 train.

to...@gmail.com <to...@gmail.com> #12Mar 6, 2020 02:47AM

Got it, thanks!

xm...@gmail.com <xm...@gmail.com> #13Mar 6, 2020 03:21AM

Is it possible to use dev version?

yb...@google.com <yb...@google.com> #14Mar 6, 2020 04:07PM

Yes, you can use the build snapshots

http://rahulrav.com/blog/using_snapshot_builds.html

Note that this is usually not recommended but at this point in time, Room master is fairly stable and has only bugfixes from the previous release.

xm...@gmail.com <xm...@gmail.com> #15Mar 17, 2020 02:22AM

Wait for the Match 18 release

da...@google.com <da...@google.com> Jul 30, 2020 12:01AM

Marked as fixed.