Fixed
Status Update
Comments
to...@gmail.com <to...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
xm...@gmail.com <xm...@gmail.com> #3
da...@google.com <da...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
xm...@gmail.com <xm...@gmail.com> #5
When release?
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 302a9bd0131103b3c4b380089bd42788111554ec
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Feb 20 11:24:57 2020
Use tracker lookup table names when creating multi-instance observer.
When creating the multi-instance invalidation tracker observer use the
table lookup keys which correspond to the available table names to
observe and not the names in the internal table names array since those
are mapped to the shadow tables and in the case of an FTS table to a
non-visible table such as Foo_content.
Bug: 148969394
Test: MultiInstanceInvalidationTest
Change-Id: Ief0a906ccd6a87d285035d65f6b4bd87837006f6
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultiInstanceInvalidationTest.java
A room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Description.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Product.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/ProductDao.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/SampleDatabase.java
M room/runtime/src/main/java/androidx/room/InvalidationTracker.java
M room/runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.java
https://android-review.googlesource.com/1241328
Branch: androidx-master-dev
commit 302a9bd0131103b3c4b380089bd42788111554ec
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Feb 20 11:24:57 2020
Use tracker lookup table names when creating multi-instance observer.
When creating the multi-instance invalidation tracker observer use the
table lookup keys which correspond to the available table names to
observe and not the names in the internal table names array since those
are mapped to the shadow tables and in the case of an FTS table to a
non-visible table such as Foo_content.
Bug: 148969394
Test: MultiInstanceInvalidationTest
Change-Id: Ief0a906ccd6a87d285035d65f6b4bd87837006f6
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultiInstanceInvalidationTest.java
A room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Description.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Product.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/ProductDao.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/SampleDatabase.java
M room/runtime/src/main/java/androidx/room/InvalidationTracker.java
M room/runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.java
da...@google.com <da...@google.com> #7
Next possible release would be on March. I'll try to set that up.
xm...@gmail.com <xm...@gmail.com> #8
Thank you, we need this. Hope soon...
an...@google.com <an...@google.com> #9
to...@gmail.com <to...@gmail.com> #10
da...@google.com <da...@google.com> #11
Room 2.2.5 with this fix will be released by March 18. Sorry but we couldn't get the cherry-pick on time for the March 4 train.
to...@gmail.com <to...@gmail.com> #12
Got it, thanks!
xm...@gmail.com <xm...@gmail.com> #13
Is it possible to use dev version?
yb...@google.com <yb...@google.com> #14
Yes, you can use the build snapshots
Note that this is usually not recommended but at this point in time, Room master is fairly stable and has only bugfixes from the previous release.
xm...@gmail.com <xm...@gmail.com> #15
Wait for the Match 18 release
Description
@Fts4(tokenizer = FtsOptions.TOKENIZER_UNICODE61)
class WorldFts(
var word: String
)
java.lang.IllegalArgumentException: There is no table with name word_fts_content
at androidx.room.InvalidationTracker.addObserver(InvalidationTracker.java:266)
at androidx.room.MultiInstanceInvalidationClient$3.run(MultiInstanceInvalidationClient.java:124)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:764)
It happens when use room Fts4 annotation with enableMultiInstanceInvalidation in room database.