Fixed
Status Update
Comments
to...@gmail.com <to...@gmail.com> #2
Related ticket:
xm...@gmail.com <xm...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c0fd11cab1b083d043dfd54c8431c4068aeef09a
Author: Matvei Malkov <malkov@google.com>
Date: Wed Nov 04 17:35:35 2020
Add Modifier.focusable
This CL adds Modifier.focusable, which is intended to be a primary way to add focusability to the app (without clicks or with custom clicks), since it contains proper a11y and InteractionState support
Change-Id: I41eb9d67669e19f8a7c20804c836a8c6dc0b5526
RelNote: "Modifier.focusable has need added in foundation. Use this to add focusable behavior to a component, with correct semantics and accessibility."
Bug: 152525426
Bug: 162865824
Bug: 163423216
Test: added
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/FocusableSample.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ScrollableSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Interaction.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
https://android-review.googlesource.com/1487281
Branch: androidx-master-dev
commit c0fd11cab1b083d043dfd54c8431c4068aeef09a
Author: Matvei Malkov <malkov@google.com>
Date: Wed Nov 04 17:35:35 2020
Add Modifier.focusable
This CL adds Modifier.focusable, which is intended to be a primary way to add focusability to the app (without clicks or with custom clicks), since it contains proper a11y and InteractionState support
Change-Id: I41eb9d67669e19f8a7c20804c836a8c6dc0b5526
RelNote: "Modifier.focusable has need added in foundation. Use this to add focusable behavior to a component, with correct semantics and accessibility."
Bug: 152525426
Bug: 162865824
Bug: 163423216
Test: added
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/FocusableSample.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ScrollableSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Interaction.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
da...@google.com <da...@google.com> #4
focusable and hoverable have been added.
Filed separate bugs for 2d scroll (
xm...@gmail.com <xm...@gmail.com> #5
When release?
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 302a9bd0131103b3c4b380089bd42788111554ec
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Feb 20 11:24:57 2020
Use tracker lookup table names when creating multi-instance observer.
When creating the multi-instance invalidation tracker observer use the
table lookup keys which correspond to the available table names to
observe and not the names in the internal table names array since those
are mapped to the shadow tables and in the case of an FTS table to a
non-visible table such as Foo_content.
Bug: 148969394
Test: MultiInstanceInvalidationTest
Change-Id: Ief0a906ccd6a87d285035d65f6b4bd87837006f6
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultiInstanceInvalidationTest.java
A room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Description.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Product.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/ProductDao.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/SampleDatabase.java
M room/runtime/src/main/java/androidx/room/InvalidationTracker.java
M room/runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.java
https://android-review.googlesource.com/1241328
Branch: androidx-master-dev
commit 302a9bd0131103b3c4b380089bd42788111554ec
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Feb 20 11:24:57 2020
Use tracker lookup table names when creating multi-instance observer.
When creating the multi-instance invalidation tracker observer use the
table lookup keys which correspond to the available table names to
observe and not the names in the internal table names array since those
are mapped to the shadow tables and in the case of an FTS table to a
non-visible table such as Foo_content.
Bug: 148969394
Test: MultiInstanceInvalidationTest
Change-Id: Ief0a906ccd6a87d285035d65f6b4bd87837006f6
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultiInstanceInvalidationTest.java
A room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Description.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Product.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/ProductDao.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/SampleDatabase.java
M room/runtime/src/main/java/androidx/room/InvalidationTracker.java
M room/runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.java
da...@google.com <da...@google.com> #7
Next possible release would be on March. I'll try to set that up.
xm...@gmail.com <xm...@gmail.com> #8
Thank you, we need this. Hope soon...
an...@google.com <an...@google.com> #9
to...@gmail.com <to...@gmail.com> #10
da...@google.com <da...@google.com> #11
Room 2.2.5 with this fix will be released by March 18. Sorry but we couldn't get the cherry-pick on time for the March 4 train.
to...@gmail.com <to...@gmail.com> #12
Got it, thanks!
xm...@gmail.com <xm...@gmail.com> #13
Is it possible to use dev version?
yb...@google.com <yb...@google.com> #14
Yes, you can use the build snapshots
Note that this is usually not recommended but at this point in time, Room master is fairly stable and has only bugfixes from the previous release.
xm...@gmail.com <xm...@gmail.com> #15
Wait for the Match 18 release
Description
@Fts4(tokenizer = FtsOptions.TOKENIZER_UNICODE61)
class WorldFts(
var word: String
)
java.lang.IllegalArgumentException: There is no table with name word_fts_content
at androidx.room.InvalidationTracker.addObserver(InvalidationTracker.java:266)
at androidx.room.MultiInstanceInvalidationClient$3.run(MultiInstanceInvalidationClient.java:124)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:764)
It happens when use room Fts4 annotation with enableMultiInstanceInvalidation in room database.