Bottom sheet component [148996320]

Fixed

Bug

Status Update

No update yet.

Description

br...@gmail.com

created issue #1

Feb 6, 2020 06:12PM

Compose doesn't currently include a bottom sheet component. It should be added.

Comments

cl...@google.com <cl...@google.com> #2Feb 10, 2020 11:50AM

Hi, thanks for reaching out and reporting this issue! Can you check and verify if you're seeing the same error when using API explorer link?

cl...@google.com <cl...@google.com> Apr 9, 2020 11:08AM

Marked as fixed, reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #3Apr 9, 2020 11:17AM

Status: Assigned (reopened)

Hi,

Thank you for quick response. Yes, I actually copied curl code above from the API explorer.

I also tried with Python code below:

request = youtube.search().list(
    part="snippet",
    maxResults=50,
    order="viewCount",
    publishedAfter="2024-09-01T00:00:00Z",
    q="artificial intelligence",
    videoPaidProductPlacement="true",
)
response = request.execute()
return response

This also gave me invalid parameter error:

TypeError: Got an unexpected keyword argument videoPaidProductPlacement

ap...@google.com <ap...@google.com> #4Sep 11, 2020 01:03PM

Hello,

I wanted to check if there are any updates regarding this issue, as it is critical for my application. Could you share whether it's planned to be resolved and if there is an estimated timeline for a fix?

I would greatly appreciate any insights you can provide.

Thank you for your time and support.

ap...@google.com <ap...@google.com> #5Sep 11, 2020 03:29PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4ebbce5de8b4a22d5fc386023f72d5fe9dd11561
Author: Calin Tataru <calintat@google.com>
Date: Thu Sep 10 09:10:57 2020

Bottom sheet scaffold component

This is a new kind of scaffold component, which implements a persistent
bottom sheet and combines with a top app bar, a floating action button,
a navigation drawer, and snackbar support, in order to construct an app
screen. Persistent bottom sheets display content that complements the
primary content of the screen and remain visible while users interact
with the primary content, making them useful for multitasking.

Bug: 113856787
Bug: 148996320
Test: TODO
Relnote: "Added experimental BottomSheetScaffold component."
Change-Id: Ie02f03288c910fbfa6702a77342eb00917050ba2

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
A compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomSheetScaffoldSamples.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt

https://android-review.googlesource.com/1421475

ap...@google.com <ap...@google.com> #6Oct 1, 2020 01:29PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ba076c6c63b7b64aab950742ec439019a68cca73
Author: Matvei Malkov <malkov@google.com>
Date: Thu Oct 01 13:53:16 2020

Add tests for BottomSheetScaffold

Fixes: 168193046
Bug: 148996320
Test: this is test
Change-Id: I8153d080c3a3ec5f170ebab7ac64438caac73196

A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt

https://android-review.googlesource.com/1442879

ma...@google.com <ma...@google.com> #7Oct 1, 2020 03:56PM

Marked as fixed.

Thanks to Calin, this big task to support BottomSheet is done! We have it and it's checked it in the code.

We need to support it in the Scaffold some day, but that's the whole another story (b/169847581).