Migrate Vector graphics to leverage VectorPainter [149030271]

Fixed

Feature Request

Status Update

No update yet.

Description

nj...@google.com

created issue #1

Feb 6, 2020 06:59PM

With the introduction of the Painter API, we need to migrate the Vector graphics implementation to leverage Painter as part of a VectorPainter implementation.

Comments

nj...@google.com <nj...@google.com> #2Mar 4, 2020 10:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Mar 13, 2020 10:36PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4dd118824b0d1b815b99c107a9dd107533057940
Author: Nader Jawad <njawad@google.com>
Date: Mon Mar 09 18:22:06 2020

Added VectorPainter API

Relnote: "Added VectorPainter API to
replace existing subcomposition API for
vector graphics. Result of subcomposition
is a VectorPainter object instead of a
DrawModifier. Deprecated previous DrawVector
composables in favor of VectorPainter.

Renamed Image(Painter) API to PaintBox(Painter)
Created Vector composable that behaves like the
Image composable except with a VectorAsset instead
of an ImageAsset"

Test: Created VectorTest
Bug:

b/149030271

Change-Id: I9af9a365eb744e0cdb343cf424f4df5160d6c2b4

M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/framework/VectorAssetTestCase.kt
M ui/ui-foundation/api/0.1.0-dev07.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev07.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ImageSamples.kt
A ui/ui-foundation/samples/src/main/res/drawable/ic_sample_vector.xml
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ImageTest.kt
A ui/ui-foundation/src/androidTest/res/drawable/ic_vector_asset_test.xml
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Icon.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Image.kt
M ui/ui-framework/api/0.1.0-dev07.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev07.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/VectorGraphicsDemo.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/PopupTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/graphics/vector/VectorInvalidationTestCase.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorAsset.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorAssetBuilder.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
A ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorPainter.kt
M ui/ui-graphics/api/0.1.0-dev07.txt
M ui/ui-graphics/api/current.txt
M ui/ui-graphics/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-graphics/api/public_plus_experimental_current.txt
M ui/ui-graphics/api/restricted_0.1.0-dev07.txt
M ui/ui-graphics/api/restricted_current.txt
M ui/ui-graphics/src/main/java/androidx/ui/graphics/ColorFilter.kt
M ui/ui-material/icons/core/samples/src/main/java/androidx/ui/material/icons/samples/IconSamples.kt
M ui/ui-material/icons/extended/src/androidTest/java/androidx/ui/material/icons/test/IconComparisonTest.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/Icons.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/FloatingActionButtonSamples.kt
M ui/ui-material/src/main/java/androidx/ui/material/DataTable.kt
M ui/ui-material/src/main/java/androidx/ui/material/FloatingActionButton.kt
M ui/ui-vector/api/0.1.0-dev07.txt
M ui/ui-vector/api/current.txt
M ui/ui-vector/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-vector/api/public_plus_experimental_current.txt
M ui/ui-vector/api/restricted_0.1.0-dev07.txt
M ui/ui-vector/api/restricted_current.txt
M ui/ui-vector/src/main/java/androidx/ui/graphics/vector/Vector.kt

https://android-review.googlesource.com/1253232

nj...@google.com <nj...@google.com> Apr 9, 2020 11:25PM

Marked as fixed.

Issue 149030271

Description

Issue summary

Comments

nj...@google.com <nj...@google.com> #2Mar 4, 2020 10:34PM

ap...@google.com <ap...@google.com> #3Mar 13, 2020 10:36PM

nj...@google.com <nj...@google.com> Apr 9, 2020 11:25PM

Add comment

Issue metadata