OutputFileResults has a null savedUri from ImageCapture#takePicture [149241379]

Fixed

Feature Request

Status Update

No update yet.

Description

sa...@withpersona.com

created issue #1

Feb 10, 2020 11:26PM

I tried upgrading the android/camera-samples (

https://github.com/android/camera-samples) project but got errors because the `OutputFileResults#getSavedUri` from `OnImageSavedCallback#onImageSaved` returned a null.

CAMERAX VERSION 1.0.0-alpha10

CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version)

ANDROID OS BUILD NUMBER: sdk_google_phone_x86-eng 5.0.2 LSY66K 5523115 test-keys

DEVICE NAME: sdk_google_phone_x86 (I also had the issue on my Pixel 4XL)

DESCRIPTION:

STEPS TO REPRODUCE:
1. Clone my modified version of `camera-samples`
```
git clone git@github.com:SalvatoreT/camera-samples.git
```
2. Run the app in Android Studio.
3. Take a photo.

OBSERVED RESULTS:
You'll see the following in logcat.

```
FATAL EXCEPTION: main
Process: com.android.example.cameraxbasic, PID: 6623
kotlin.KotlinNullPointerException
at com.android.example.cameraxbasic.fragments.CameraFragment$imageSavedListener$1.onImageSaved(CameraFragment.kt:196)
at androidx.camera.core.ImageCapture$2.onImageSaved(ImageCapture.java:642)
at androidx.camera.core.ImageSaver$1.run(ImageSaver.java:242)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5221)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
```

EXPECTED RESULTS: Not a crash.

REPRODUCIBILITY: every time

CODE FRAGMENTS: Here are the changes I made.

https://github.com/SalvatoreT/camera-samples/commit/6d86c01d02daac01513cdce1d124131b1f22289d

Comments

er...@google.com <er...@google.com> #2Feb 10, 2020 11:43PM

Reassigned to xi...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

xi...@google.com <xi...@google.com> #3Feb 11, 2020 12:39AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

er...@google.com <er...@google.com> Feb 11, 2020 01:23AM

Reassigned to sa...@withpersona.com.

sa...@withpersona.com <sa...@withpersona.com> #4Feb 11, 2020 06:42PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

xi...@google.com <xi...@google.com> #5Feb 11, 2020 07:09PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

sa...@withpersona.com <sa...@withpersona.com> #6Feb 11, 2020 11:03PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

sa...@withpersona.com <sa...@withpersona.com> #7Feb 11, 2020 11:05PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

Message last modified on Mar 11, 2025 08:52PM

er...@google.com <er...@google.com> #8Feb 20, 2020 12:27AM

Reassigned to ca...@google.com.

Thank you, I'll try it and check.

fu...@google.com <fu...@google.com> Jul 12, 2021 09:17PM

Reassigned to xi...@google.com.

ap...@google.com <ap...@google.com> #9Jul 21, 2021 08:16PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.

xi...@google.com <xi...@google.com> Jul 21, 2021 11:31PM

Marked as fixed.