Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 235b4fa6ab69b620dd1a336b683ba4161ecf5d22
Author: Matvei Malkov <malkov@google.com>
Date: Tue Jul 07 21:14:49 2020
Deprecate Scroller. Introduce ScrollableColumn / ScrollableRow
This CL reworks Scrolling-related API. Scrollers and ScrollerPosition have been deprecated. Instead, ScrollableColumn, ScrollableRow and ScrollState have been introduced. Additionaly, for more flexibility and performance, Modifier.verticalScroll and Modifier.horizontalScroll have been introduced, so users can add scrolling to everything while saving layout node.
While moving from ScrollerPosition to ScrollState, few API were renamed and simplified and @Composable ScrollerPosition was replaced with rememberScrollState.
Relnote: 'VerticalScroller and HoriziontalScroller have been deprecated. Use ScrollableColumn and ScrollableRow for build-in experience with Column/Row behaviour and parameters, or Modifier.verticalScroll and Modifier.horizontalScroll on your own element. Similarly, ScrollerPosition has been deprecated in favor of ScrollState'
Fixes: 158571223
Fixes: 157225838
Bug: 148542949
Bug: 150706555
Fixes: 150458415
Fixes: 149460415
Fixes: 154105299
Test: Tests were fixed for new APIs
Change-Id: I400ce0e6c0e33aa865e0e49defef1eb92ac40a93
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoFilter.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/foundation/NestedScrollerTestCase.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/foundation/ScrollerTestCase.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/PointerInputInteropAndroidInCompose.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/PointerInputInteropComposeInAndroid.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/PopupDemo.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ScrollerSamples.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/ui/foundation/ScrollTest.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingConfig.kt
A ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/Scroll.kt
D ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/Scroller.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ButtonDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/DynamicThemeActivity.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ElevationDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ListItemDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/MaterialTextField.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ProgressIndicatorDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/SelectionControlsDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/SnackbarDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/TabDemo.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/AccountsScreen.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/BillsScreen.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/OverviewScreen.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/ScaffoldSamples.kt
M ui/ui-material/src/main/java/androidx/ui/material/Menu.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/IsDisplayedTest.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldFocusTransition.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldTrickyUseCase.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeMultiParagraph.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeText.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeTextSelection.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeTextSelectionSample.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeVariousInputField.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/InteractiveText.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/TextFieldWIthScroller.kt
https://android-review.googlesource.com/1355660
Branch: androidx-master-dev
commit 235b4fa6ab69b620dd1a336b683ba4161ecf5d22
Author: Matvei Malkov <malkov@google.com>
Date: Tue Jul 07 21:14:49 2020
Deprecate Scroller. Introduce ScrollableColumn / ScrollableRow
This CL reworks Scrolling-related API. Scrollers and ScrollerPosition have been deprecated. Instead, ScrollableColumn, ScrollableRow and ScrollState have been introduced. Additionaly, for more flexibility and performance, Modifier.verticalScroll and Modifier.horizontalScroll have been introduced, so users can add scrolling to everything while saving layout node.
While moving from ScrollerPosition to ScrollState, few API were renamed and simplified and @Composable ScrollerPosition was replaced with rememberScrollState.
Relnote: 'VerticalScroller and HoriziontalScroller have been deprecated. Use ScrollableColumn and ScrollableRow for build-in experience with Column/Row behaviour and parameters, or Modifier.verticalScroll and Modifier.horizontalScroll on your own element. Similarly, ScrollerPosition has been deprecated in favor of ScrollState'
Fixes: 158571223
Fixes: 157225838
Bug: 148542949
Bug: 150706555
Fixes: 150458415
Fixes: 149460415
Fixes: 154105299
Test: Tests were fixed for new APIs
Change-Id: I400ce0e6c0e33aa865e0e49defef1eb92ac40a93
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoFilter.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/foundation/NestedScrollerTestCase.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/foundation/ScrollerTestCase.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/PointerInputInteropAndroidInCompose.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/PointerInputInteropComposeInAndroid.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/PopupDemo.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ScrollerSamples.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/ui/foundation/ScrollTest.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingConfig.kt
A ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/Scroll.kt
D ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/Scroller.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ButtonDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/DynamicThemeActivity.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ElevationDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ListItemDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/MaterialTextField.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ProgressIndicatorDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/SelectionControlsDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/SnackbarDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/TabDemo.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/AccountsScreen.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/BillsScreen.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/OverviewScreen.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/ScaffoldSamples.kt
M ui/ui-material/src/main/java/androidx/ui/material/Menu.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/IsDisplayedTest.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldFocusTransition.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldTrickyUseCase.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeMultiParagraph.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeText.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeTextSelection.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeTextSelectionSample.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeVariousInputField.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/InteractiveText.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/TextFieldWIthScroller.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 710fb4fccdd3c7210af3173123dcdee526f75dc5
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jul 03 15:53:10 2020
Refactor draggable, scrollable and fling config
This CL refactors drag/scroll/fling related APIs to bring more clarity, consistency, and easiness of use.
Details:
* Concept of DragDirection has been removed. We now have Orientation in ui-core and reverseDirection, to support scroller reverse and rtl support when needed on the callee side
* draggable has been simplified. Density added as a scope in onDragDelta for convenience. Capability of nested dragging was removed, because the absence of nested dragging is the right default
* flingConfig signature was refactored according to API council feedback. onAnimationEnd is now a part of fling method, which removed a lot of copying of fling configs and separated concers more correctly there.
* @Composable constructor-like construction were removed for fling config and scrollable, and were either substituted with the stateless alternatives of renamed to camelCase for correctness
Relnote: "Modifier.draggable and Modifier.scrollable APIs were reworked. DragDirection was removed in favor of Orientation. State required for scrollable has beed simplified. ScrollableState has been renamed to ScrollableController"
Fixes: 159614257
Fixes: 150774151
Fixes: 159618405
Fixes: 159616989
Fixes: 159614137
Bug: 148542949
Bug: 150706555
Fixes: 149460415
Test: were moved to new APIs, should pass + demos
Change-Id: Iab63cb65002471a5173f387f7bc6720aa929f9e6
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/HighLevelGesturesDemo.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DraggableSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/InteractionStateSample.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ScrollableSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ZoomableSample.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/ui/foundation/ScrollableTest.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingCalculator.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingConfig.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingDecaySpec.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingSpline.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/animation/FlingConfig.kt
D ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/gestures/DragDirection.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/gestures/Draggable.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/gestures/Scrollable.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/lazy/LazyItems.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/lazy/LazyItemsState.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-material/src/main/java/androidx/ui/material/internal/StateDraggable.kt
https://android-review.googlesource.com/1354572
Branch: androidx-master-dev
commit 710fb4fccdd3c7210af3173123dcdee526f75dc5
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jul 03 15:53:10 2020
Refactor draggable, scrollable and fling config
This CL refactors drag/scroll/fling related APIs to bring more clarity, consistency, and easiness of use.
Details:
* Concept of DragDirection has been removed. We now have Orientation in ui-core and reverseDirection, to support scroller reverse and rtl support when needed on the callee side
* draggable has been simplified. Density added as a scope in onDragDelta for convenience. Capability of nested dragging was removed, because the absence of nested dragging is the right default
* flingConfig signature was refactored according to API council feedback. onAnimationEnd is now a part of fling method, which removed a lot of copying of fling configs and separated concers more correctly there.
* @Composable constructor-like construction were removed for fling config and scrollable, and were either substituted with the stateless alternatives of renamed to camelCase for correctness
Relnote: "Modifier.draggable and Modifier.scrollable APIs were reworked. DragDirection was removed in favor of Orientation. State required for scrollable has beed simplified. ScrollableState has been renamed to ScrollableController"
Fixes: 159614257
Fixes: 150774151
Fixes: 159618405
Fixes: 159616989
Fixes: 159614137
Bug: 148542949
Bug: 150706555
Fixes: 149460415
Test: were moved to new APIs, should pass + demos
Change-Id: Iab63cb65002471a5173f387f7bc6720aa929f9e6
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/HighLevelGesturesDemo.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DraggableSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/InteractionStateSample.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ScrollableSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ZoomableSample.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/ui/foundation/ScrollableTest.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingCalculator.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingConfig.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingDecaySpec.kt
M ui/ui-foundation/src/androidMain/kotlin/androidx/ui/foundation/animation/AndroidFlingSpline.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/animation/FlingConfig.kt
D ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/gestures/DragDirection.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/gestures/Draggable.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/gestures/Scrollable.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/lazy/LazyItems.kt
M ui/ui-foundation/src/commonMain/kotlin/androidx/ui/foundation/lazy/LazyItemsState.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-material/src/main/java/androidx/ui/material/internal/StateDraggable.kt
Description