Fixed
Status Update
No update yet.
Comments
ma...@google.com
ma...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020
Rename BottomNavigationItem parameters
text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state
Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
https://android-review.googlesource.com/1373097
Branch: androidx-master-dev
commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020
Rename BottomNavigationItem parameters
text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state
Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
ap...@google.com
Discussed further offline, onSelect should be renamed to onClick for consistency (with Tab and other components).
Description
all required information.
Android Studio Build: 4.0 canary 9
Version of Gradle Plugin: 1.3.61
Version of Gradle: 6.1
Version of Java: 1.8
OS: Linux
Steps to Reproduce:
Per slack conversation with Ryan Mently:
My use case: Another question (heh): How do I enable/disable a component in compose? Is there some sort of Composable I nest it inside or some other concept? (In my case I have a list of bluetooth devices RadioGroupTextItems inside of a RadioGroup. And I want some of those items to be drawn grey/disabled because they are not yet paired with the phone (so I want the user to know they exist, but you can't yet select them)
Ryan's comment: which would be that you disable components by not providing the onWhatever callback - see, for example, Button, which handles this ... RadioButton, unfortunately, does not yet, which would be a good feature request