Fixed
Status Update
No update yet.
Comments
ma...@google.com
ma...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 7046b043da432d5b8c0a58efdc5b3d1d30b90bc4
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jun 12 13:17:46 2020
RadioButton rework 3
This CL reworks RadioButton and related infrastructure around it, namely:
* RadioGroups has been deprecated, as they serve no real purpose in the real app and it's easy to do yourself with Box, Modifier.Selectable and a Column and Row
* RadioGroupItems and RadioGroupScope were deprecated for the same reason as RadioGroup
* Added more params to RadioButton for better customization
* Added enabled/disabled state to RadioButton
* new, simpler animation for RadioButton
* misc API feedback
Relnote: RadioGroup and RadioGroupItem have been deprecated. Use Box with Modifier.selectable, Row and Column to make proper set of radioButton choices by your design
Relnote: API rework for RadioButton. callback was renamed to onClick, new parameters for customization were added
Fixes: 149528535
Fixes: 144798035
Fixes: 152919315
Fixes: 144797753
Test: rewrote old tests, added new screenshot tests
Change-Id: I7f5cf83c411fe9ad21eecf211544b868bac17fb5
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/RadioGroupBenchmark.kt
M ui/ui-material/api/0.1.0-dev14.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev14.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/BottomNavigationDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/MaterialTextField.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/SelectionControlsDemo.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/SelectionControlsSamples.kt
A ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
https://android-review.googlesource.com/1331084
Branch: androidx-master-dev
commit 7046b043da432d5b8c0a58efdc5b3d1d30b90bc4
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jun 12 13:17:46 2020
RadioButton rework 3
This CL reworks RadioButton and related infrastructure around it, namely:
* RadioGroups has been deprecated, as they serve no real purpose in the real app and it's easy to do yourself with Box, Modifier.Selectable and a Column and Row
* RadioGroupItems and RadioGroupScope were deprecated for the same reason as RadioGroup
* Added more params to RadioButton for better customization
* Added enabled/disabled state to RadioButton
* new, simpler animation for RadioButton
* misc API feedback
Relnote: RadioGroup and RadioGroupItem have been deprecated. Use Box with Modifier.selectable, Row and Column to make proper set of radioButton choices by your design
Relnote: API rework for RadioButton. callback was renamed to onClick, new parameters for customization were added
Fixes: 149528535
Fixes: 144798035
Fixes: 152919315
Fixes: 144797753
Test: rewrote old tests, added new screenshot tests
Change-Id: I7f5cf83c411fe9ad21eecf211544b868bac17fb5
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/RadioGroupBenchmark.kt
M ui/ui-material/api/0.1.0-dev14.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev14.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/BottomNavigationDemo.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/MaterialTextField.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/SelectionControlsDemo.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/SelectionControlsSamples.kt
A ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
Description
all required information.
Android Studio Build: 4.0 canary 9
Version of Gradle Plugin: 1.3.61
Version of Gradle: 6.1
Version of Java: 1.8
OS: Linux
Steps to Reproduce:
Per slack conversation with Ryan Mently:
My use case: Another question (heh): How do I enable/disable a component in compose? Is there some sort of Composable I nest it inside or some other concept? (In my case I have a list of bluetooth devices RadioGroupTextItems inside of a RadioGroup. And I want some of those items to be drawn grey/disabled because they are not yet paired with the phone (so I want the user to know they exist, but you can't yet select them)
Ryan's comment: which would be that you disable components by not providing the onWhatever callback - see, for example, Button, which handles this ... RadioButton, unfortunately, does not yet, which would be a good feature request