DialogFragmentNavigator doesn't take into account launchSingleTop [149572817]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 14, 2020 10:05PM

Component used: Navigation
Version used: 2.3.0-alpha01
Devices/Android versions reproduced on: any

When having <dialog> in navgraph, it doesn't handle action having launchSingleTop="true" which results in user being able to show the same dialog multiple times, which is (almost) never proper case?

I was checking briefly implementation of DialogFragmentNavigator and there's no code handling this as opposed to FragmentNavigator.

Is this a bug?

Thanks

Comments

il...@google.com <il...@google.com> #2Feb 14, 2020 10:54PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

[Deleted User] <[Deleted User]> #3Feb 14, 2020 11:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

il...@google.com <il...@google.com> Mar 5, 2020 12:47AM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Nov 1, 2022 04:51PM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> #4Dec 9, 2022 12:55AM

Accepted by cl...@google.com.

Comment has been deleted.

Message last modified on Dec 9, 2022 01:38AM

MyApplication.zip

16 MB

Download

cl...@google.com <cl...@google.com> #5Dec 9, 2022 01:45AM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

cl...@google.com <cl...@google.com> Dec 10, 2022 01:14AM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #6Jan 10, 2023 01:06AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4b53d868961afe7dd6358bf487f81c17a8cde8ee
Author: Clara Fok <clarafok@google.com>
Date: Fri Dec 09 17:12:26 2022

Fix DialogFragmentNavigator launchSingleTop

DialogFragmentNavigator did not implement its own onLaunchSingleTop to override the default Navigator onLaunchSingleTop.

Now its own implementation will replace the old DialogFragment with a new intsance upon singleTop navigaiton.

Test: ./graldew navigation:navigation-fragment:cC
Bug: 149572817
Relnote: "Navigation will now properly replace the DialogFragment instance when navigating to the same destination and setting the `launchSingleTop` flag to true."
Change-Id: I45b5a3bd6f538c1b97573f269414ecf6e06e4d81

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt

https://android-review.googlesource.com/2336208

cl...@google.com <cl...@google.com> #7Jan 10, 2023 01:14AM