DialogFragmentNavigator doesn't take into account launchSingleTop [149572817]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 14, 2020 10:05PM

Component used: Navigation
Version used: 2.3.0-alpha01
Devices/Android versions reproduced on: any

When having <dialog> in navgraph, it doesn't handle action having launchSingleTop="true" which results in user being able to show the same dialog multiple times, which is (almost) never proper case?

I was checking briefly implementation of DialogFragmentNavigator and there's no code handling this as opposed to FragmentNavigator.

Is this a bug?

Thanks

Comments

il...@google.com <il...@google.com> #2Feb 14, 2020 10:54PM

since these are in public API (:/) we need to do this in 1.2

[Deleted User] <[Deleted User]> #3Feb 14, 2020 11:04PM

since it is already marked as deprecated, we can probably do it by now.

il...@google.com <il...@google.com> Mar 5, 2020 12:47AM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Nov 1, 2022 04:51PM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> #4Dec 9, 2022 12:55AM

Accepted by cl...@google.com.

Comment has been deleted.

Message last modified on Dec 9, 2022 01:38AM

MyApplication.zip

16 MB

Download

cl...@google.com <cl...@google.com> #5Dec 9, 2022 01:45AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

cl...@google.com <cl...@google.com> Dec 10, 2022 01:14AM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #6Jan 10, 2023 01:06AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4b53d868961afe7dd6358bf487f81c17a8cde8ee
Author: Clara Fok <clarafok@google.com>
Date: Fri Dec 09 17:12:26 2022

Fix DialogFragmentNavigator launchSingleTop

DialogFragmentNavigator did not implement its own onLaunchSingleTop to override the default Navigator onLaunchSingleTop.

Now its own implementation will replace the old DialogFragment with a new intsance upon singleTop navigaiton.

Test: ./graldew navigation:navigation-fragment:cC
Bug: 149572817
Relnote: "Navigation will now properly replace the DialogFragment instance when navigating to the same destination and setting the `launchSingleTop` flag to true."
Change-Id: I45b5a3bd6f538c1b97573f269414ecf6e06e4d81

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt

https://android-review.googlesource.com/2336208

cl...@google.com <cl...@google.com> #7Jan 10, 2023 01:14AM

Marked as fixed.

This has been fixed internally and will be available in navigation 2.6.0-alpha05

pr...@google.com <pr...@google.com> #8Feb 8, 2023 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha05