Fixed
Status Update
No update yet.
Comments
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
[Deleted User] <[Deleted User]>
il...@google.com
il...@google.com
cl...@google.com
Reproducible in 2.3.0-alpha01 but not as of 2.6.0-alpha04.
cl...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4b53d868961afe7dd6358bf487f81c17a8cde8ee
Author: Clara Fok <clarafok@google.com>
Date: Fri Dec 09 17:12:26 2022
Fix DialogFragmentNavigator launchSingleTop
DialogFragmentNavigator did not implement its own onLaunchSingleTop to override the default Navigator onLaunchSingleTop.
Now its own implementation will replace the old DialogFragment with a new intsance upon singleTop navigaiton.
Test: ./graldew navigation:navigation-fragment:cC
Bug: 149572817
Relnote: "Navigation will now properly replace the DialogFragment instance when navigating to the same destination and setting the `launchSingleTop` flag to true."
Change-Id: I45b5a3bd6f538c1b97573f269414ecf6e06e4d81
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt
https://android-review.googlesource.com/2336208
Branch: androidx-main
commit 4b53d868961afe7dd6358bf487f81c17a8cde8ee
Author: Clara Fok <clarafok@google.com>
Date: Fri Dec 09 17:12:26 2022
Fix DialogFragmentNavigator launchSingleTop
DialogFragmentNavigator did not implement its own onLaunchSingleTop to override the default Navigator onLaunchSingleTop.
Now its own implementation will replace the old DialogFragment with a new intsance upon singleTop navigaiton.
Test: ./graldew navigation:navigation-fragment:cC
Bug: 149572817
Relnote: "Navigation will now properly replace the DialogFragment instance when navigating to the same destination and setting the `launchSingleTop` flag to true."
Change-Id: I45b5a3bd6f538c1b97573f269414ecf6e06e4d81
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt
cl...@google.com
This has been fixed internally and will be available in navigation 2.6.0-alpha05
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.6.0-alpha05
Description
Version used: 2.3.0-alpha01
Devices/Android versions reproduced on: any
When having <dialog> in navgraph, it doesn't handle action having launchSingleTop="true" which results in user being able to show the same dialog multiple times, which is (almost) never proper case?
I was checking briefly implementation of DialogFragmentNavigator and there's no code handling this as opposed to FragmentNavigator.
Is this a bug?
Thanks