DialogFragmentNavigator doesn't take into account launchSingleTop [149572817]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 14, 2020 10:05PM

Component used: Navigation
Version used: 2.3.0-alpha01
Devices/Android versions reproduced on: any

When having <dialog> in navgraph, it doesn't handle action having launchSingleTop="true" which results in user being able to show the same dialog multiple times, which is (almost) never proper case?

I was checking briefly implementation of DialogFragmentNavigator and there's no code handling this as opposed to FragmentNavigator.

Is this a bug?

Thanks

Comments

il...@google.com <il...@google.com> #2Feb 14, 2020 10:54PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

[Deleted User] <[Deleted User]> #3Feb 14, 2020 11:04PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

il...@google.com <il...@google.com> Mar 5, 2020 12:47AM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Nov 1, 2022 04:51PM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> #4Dec 9, 2022 12:55AM

Accepted by cl...@google.com.

Comment has been deleted.

Message last modified on Dec 9, 2022 01:38AM

MyApplication.zip

16 MB

Download

cl...@google.com <cl...@google.com> #5Dec 9, 2022 01:45AM

Marked as fixed.

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

cl...@google.com <cl...@google.com> Dec 10, 2022 01:14AM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #6Jan 10, 2023 01:06AM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

cl...@google.com <cl...@google.com> #7Jan 10, 2023 01:14AM

Marked as fixed.

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

pr...@google.com <pr...@google.com> #8Feb 8, 2023 06:21PM

Thank you, I'll try it and check.