BiometricPrompt should fall back to inserting pin/password/pattern when no biometric hardware is present. [149579143]

Fixed

Feature Request

[AOSP] assigned

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Feb 15, 2020 02:24PM

Currenly BiometricPrompt::authenticate() just exists (with error callback) when no biometric hardware support is detected.
That is an issue because apps will start using it as their default authentication method. This includes the AOSP Settings app, which uses BiometricPrompt to authenticate the user when generating a WiFi QR-Code to share (Wi-Fi DPP). When trying to do so on a locked device with no biometric hardware, simply nothing happens.

I propose that BiometricPrompt should fall back to asking for pin/password/pattern.
Alternatively, a new API could be introduced for prompting the user to authenticate, which would call BiometricPrompt if hardware is present, else direclty show a PIN/password/pattern insertion activity.

Comments

vk...@google.com <vk...@google.com> Feb 17, 2020 03:07AM

Assigned to vk...@google.com.

al...@gmail.com <al...@gmail.com> #2Feb 17, 2020 08:52AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019

API lint check for the MinMaxConstant is enabled for androidx

Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25

M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java

https://android-review.googlesource.com/1114511

https://goto.google.com/android-sha1/64f11e5722d8a574ccb72bfb042fa89f51129c68

vk...@google.com <vk...@google.com> #3Feb 17, 2020 11:49AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019

API lint check for the SetterReturnsThis is enabled for androidx

Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1123398

https://goto.google.com/android-sha1/536a1ff3c3c7623ef60ef89b45266afd63ca748f

vk...@google.com <vk...@google.com> Feb 17, 2020 01:02PM

Reassigned to an...@google.com.

sh...@gmail.com <sh...@gmail.com> #4Feb 20, 2020 09:10AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019

API lint check for the PackageLayering is enabled for androidx

PackageLayering is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126765

https://goto.google.com/android-sha1/8aecbea988804f4f702812f6e7f50bc60359eed1

al...@gmail.com <al...@gmail.com> #5Feb 24, 2020 08:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 7426c6889ba80df99b2589454d0f604e0efd7b78
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:39:30 2019

API lint check for the OverlappingConstants is enabled for androidx

OverlappingConstants is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I312b39963b0b64e06a3bd5933156dc88bff76a1c

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126766

https://goto.google.com/android-sha1/7426c6889ba80df99b2589454d0f604e0efd7b78

cu...@google.com <cu...@google.com> Aug 17, 2020 06:53PM

Reassigned to cu...@google.com.

cu...@google.com <cu...@google.com> Sep 21, 2020 11:17PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #6Sep 22, 2020 06:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9108b6016c27854f67c529a98506f93ff3631a26
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:50:54 2019

API lint check for the IllegalStateException is enabled for androidx

IllegalStateException is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I025bd3b1ade7204b78b6c66b2b205a99ccc701cc

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126767

https://goto.google.com/android-sha1/9108b6016c27854f67c529a98506f93ff3631a26