IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Feel free to leave this as duplicate, but this is the deprecation, and the other is removal, so they are blocked on each other, but not the same :)

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 078da4407f440a78cac42e39af5e03261a66555a
Author: Matvei Malkov <malkov@google.com>
Date:   Wed Feb 19 15:41:27 2020

    Remove DrawImage
   
    This CL removes DrawImage composable as part of Draw tag removal
   
    RelNote: DrawImage composable was removed. Use ImagePainter to draw image on existing layout, or SimpleImage to introduce Image that takes space
   
    Test: existed tests should pass
    Bug: 149827027
    Change-Id: I595e1cac09eb1d275b3b1ded2c2ce05b3f4b41bb

M       ui/ui-foundation/api/0.1.0-dev06.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev06.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev06.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Image.kt

https://android-review.googlesource.com/1238325

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d2519432097cd190b7083c22c03ae2c62a4e9559
Author: Matvei Malkov <malkov@google.com>
Date:   Fri Feb 21 16:31:43 2020

    Remove Draw usages from animation demos
   
    As part of Draw tag deprecation, all animation demos were changes to use
    either Canvas (mostly) or Box with background
   
    Bug: 149827027
    Test: demos are correct
    Change-Id: Ib4484ddaa7275e647deaffc6a78268a065b3bb56

M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/AnimatableSeekBar.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/CrossfadeActivity.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/FancyScrolling.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/HelloAnimationActivity.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/HelloGestureBasedAnimationActivity.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/MultiDimensionalAnimation.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/RepeatedRotationActivity.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SingleValueAnimation.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SpringBackScrolling.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/StateBasedRippleAnimation.kt
M       ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SwipeToDismiss.kt

https://android-review.googlesource.com/1242690

Project: platform/frameworks/support
Branch: androidx-master-dev

commit cda7a18f50aec887baa68ab8910f25d433aee7e5
Author: Matvei Malkov <malkov@google.com>
Date:   Fri Feb 21 18:15:57 2020

    Remove Draw tag in ui-framework tests
   
    This CL continues Draw usages removal. It removes all the Draw tag
    usages inside ui-framework tests and leaves only direct Draw tag tests
    and repaintBoundary tests
   
    Bug: 149827027
    Test: after this changes tests should pass
    Change-Id: I29bf33f5a79bf10892de9bc589188156c64ae1e2

M       ui/ui-framework/src/androidTest/java/androidx/ui/core/PainterModifierTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/DrawShadowTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ModelReadsTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ParentDataTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/graphics/vector/VectorInvalidationTestCase.kt

https://android-review.googlesource.com/1242991

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2e66e76f0f46827e98cbe712f353f91ce2209fe3
Author: Matvei Malkov <malkov@google.com>
Date:   Tue Feb 25 11:47:19 2020

    Remove Draw tag usages in Text
   
    As part of Draw tag removal, this CL removes Draw usages in text
    selection logic. Rewrites Draw to draw modifier.
   
    Bug: 149827027
    Test: demos work fine + tests should pass
    Change-Id: I4065a988b95848e9a0555b3365505a70b7299855

M       ui/ui-framework/src/main/java/androidx/ui/core/Text.kt
M       ui/ui-framework/src/main/java/androidx/ui/core/TextField.kt
M       ui/ui-framework/src/main/java/androidx/ui/core/selection/SelectionHandles.kt

https://android-review.googlesource.com/1242993

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9f229d7f8ccdc82186f5edbe158f6b8598c145a2
Author: Matvei Malkov <malkov@google.com>
Date:   Wed Feb 26 14:06:29 2020

    Deprecate Draw tag
   
    This CL deprecates Draw tag, both versions: with and without the
    children. All existing usages (tooling, repaintBoundaries, tests for
    George to figure out) are supressing this error, corresponding bug are
    filed. Deprecation message states that draw modifier or Canvas should be
    used instead.
   
    RelNote: Deprecated: Draw composable is a common source of bugs as it's
    not a layout and takes parent size, but doesn't tell you that. Therefore, layout strategies, like Row
    or Column doesn't work with Draw. You should use androidx.ui.core.draw modifier if you want to
    decorate existent layout with custom drawing, use existent drawing modifiers (DrawBackground,
    DrawBorder, PainterModifier) or use androidx.ui.foundation.Canvas to make a layout that takes space
    and allows custom drawing.
   
    Bug: 149827027
    Test: tests should pass
    Change-Id: I78392f01c2d37c2419812478d96417a1b8a1293d

M       ui/ui-foundation/src/main/java/androidx/ui/foundation/TableBorders.kt
M       ui/ui-framework/api/0.1.0-dev06.txt
M       ui/ui-framework/api/current.txt
M       ui/ui-framework/api/public_plus_experimental_0.1.0-dev06.txt
M       ui/ui-framework/api/public_plus_experimental_current.txt
M       ui/ui-framework/api/restricted_0.1.0-dev06.txt
M       ui/ui-framework/api/restricted_current.txt
D       ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawSample.kt
D       ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawWithChildrenSample.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OpacityTest.kt
M       ui/ui-framework/src/main/java/androidx/ui/core/Draw.kt
M       ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M       ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M       ui/ui-material/src/main/java/androidx/ui/material/surface/Surface.kt
M       ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt

https://android-review.googlesource.com/1244127