Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ma...@google.com <ma...@google.com> #3
Feel free to leave this as duplicate, but this is the deprecation, and the other is removal, so they are blocked on each other, but not the same :)
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 078da4407f440a78cac42e39af5e03261a66555a
Author: Matvei Malkov <malkov@google.com>
Date: Wed Feb 19 15:41:27 2020
Remove DrawImage
This CL removes DrawImage composable as part of Draw tag removal
RelNote: DrawImage composable was removed. Use ImagePainter to draw image on existing layout, or SimpleImage to introduce Image that takes space
Test: existed tests should pass
Bug: 149827027
Change-Id: I595e1cac09eb1d275b3b1ded2c2ce05b3f4b41bb
M ui/ui-foundation/api/0.1.0-dev06.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev06.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev06.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Image.kt
https://android-review.googlesource.com/1238325
Branch: androidx-master-dev
commit 078da4407f440a78cac42e39af5e03261a66555a
Author: Matvei Malkov <malkov@google.com>
Date: Wed Feb 19 15:41:27 2020
Remove DrawImage
This CL removes DrawImage composable as part of Draw tag removal
RelNote: DrawImage composable was removed. Use ImagePainter to draw image on existing layout, or SimpleImage to introduce Image that takes space
Test: existed tests should pass
Bug: 149827027
Change-Id: I595e1cac09eb1d275b3b1ded2c2ce05b3f4b41bb
M ui/ui-foundation/api/0.1.0-dev06.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev06.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev06.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Image.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d2519432097cd190b7083c22c03ae2c62a4e9559
Author: Matvei Malkov <malkov@google.com>
Date: Fri Feb 21 16:31:43 2020
Remove Draw usages from animation demos
As part of Draw tag deprecation, all animation demos were changes to use
either Canvas (mostly) or Box with background
Bug: 149827027
Test: demos are correct
Change-Id: Ib4484ddaa7275e647deaffc6a78268a065b3bb56
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/AnimatableSeekBar.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/CrossfadeActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/FancyScrolling.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/HelloAnimationActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/HelloGestureBasedAnimationActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/MultiDimensionalAnimation.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/RepeatedRotationActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SingleValueAnimation.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SpringBackScrolling.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/StateBasedRippleAnimation.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SwipeToDismiss.kt
https://android-review.googlesource.com/1242690
Branch: androidx-master-dev
commit d2519432097cd190b7083c22c03ae2c62a4e9559
Author: Matvei Malkov <malkov@google.com>
Date: Fri Feb 21 16:31:43 2020
Remove Draw usages from animation demos
As part of Draw tag deprecation, all animation demos were changes to use
either Canvas (mostly) or Box with background
Bug: 149827027
Test: demos are correct
Change-Id: Ib4484ddaa7275e647deaffc6a78268a065b3bb56
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/AnimatableSeekBar.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/CrossfadeActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/FancyScrolling.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/HelloAnimationActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/HelloGestureBasedAnimationActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/MultiDimensionalAnimation.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/RepeatedRotationActivity.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SingleValueAnimation.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SpringBackScrolling.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/StateBasedRippleAnimation.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SwipeToDismiss.kt
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit cda7a18f50aec887baa68ab8910f25d433aee7e5
Author: Matvei Malkov <malkov@google.com>
Date: Fri Feb 21 18:15:57 2020
Remove Draw tag in ui-framework tests
This CL continues Draw usages removal. It removes all the Draw tag
usages inside ui-framework tests and leaves only direct Draw tag tests
and repaintBoundary tests
Bug: 149827027
Test: after this changes tests should pass
Change-Id: I29bf33f5a79bf10892de9bc589188156c64ae1e2
M ui/ui-framework/src/androidTest/java/androidx/ui/core/PainterModifierTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/DrawShadowTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ModelReadsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ParentDataTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/graphics/vector/VectorInvalidationTestCase.kt
https://android-review.googlesource.com/1242991
Branch: androidx-master-dev
commit cda7a18f50aec887baa68ab8910f25d433aee7e5
Author: Matvei Malkov <malkov@google.com>
Date: Fri Feb 21 18:15:57 2020
Remove Draw tag in ui-framework tests
This CL continues Draw usages removal. It removes all the Draw tag
usages inside ui-framework tests and leaves only direct Draw tag tests
and repaintBoundary tests
Bug: 149827027
Test: after this changes tests should pass
Change-Id: I29bf33f5a79bf10892de9bc589188156c64ae1e2
M ui/ui-framework/src/androidTest/java/androidx/ui/core/PainterModifierTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/DrawShadowTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ModelReadsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ParentDataTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/graphics/vector/VectorInvalidationTestCase.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2e66e76f0f46827e98cbe712f353f91ce2209fe3
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 25 11:47:19 2020
Remove Draw tag usages in Text
As part of Draw tag removal, this CL removes Draw usages in text
selection logic. Rewrites Draw to draw modifier.
Bug: 149827027
Test: demos work fine + tests should pass
Change-Id: I4065a988b95848e9a0555b3365505a70b7299855
M ui/ui-framework/src/main/java/androidx/ui/core/Text.kt
M ui/ui-framework/src/main/java/androidx/ui/core/TextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/selection/SelectionHandles.kt
https://android-review.googlesource.com/1242993
Branch: androidx-master-dev
commit 2e66e76f0f46827e98cbe712f353f91ce2209fe3
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 25 11:47:19 2020
Remove Draw tag usages in Text
As part of Draw tag removal, this CL removes Draw usages in text
selection logic. Rewrites Draw to draw modifier.
Bug: 149827027
Test: demos work fine + tests should pass
Change-Id: I4065a988b95848e9a0555b3365505a70b7299855
M ui/ui-framework/src/main/java/androidx/ui/core/Text.kt
M ui/ui-framework/src/main/java/androidx/ui/core/TextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/selection/SelectionHandles.kt
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9f229d7f8ccdc82186f5edbe158f6b8598c145a2
Author: Matvei Malkov <malkov@google.com>
Date: Wed Feb 26 14:06:29 2020
Deprecate Draw tag
This CL deprecates Draw tag, both versions: with and without the
children. All existing usages (tooling, repaintBoundaries, tests for
George to figure out) are supressing this error, corresponding bug are
filed. Deprecation message states that draw modifier or Canvas should be
used instead.
RelNote: Deprecated: Draw composable is a common source of bugs as it's
not a layout and takes parent size, but doesn't tell you that. Therefore, layout strategies, like Row
or Column doesn't work with Draw. You should use androidx.ui.core.draw modifier if you want to
decorate existent layout with custom drawing, use existent drawing modifiers (DrawBackground,
DrawBorder, PainterModifier) or use androidx.ui.foundation.Canvas to make a layout that takes space
and allows custom drawing.
Bug: 149827027
Test: tests should pass
Change-Id: I78392f01c2d37c2419812478d96417a1b8a1293d
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TableBorders.kt
M ui/ui-framework/api/0.1.0-dev06.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev06.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev06.txt
M ui/ui-framework/api/restricted_current.txt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawSample.kt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawWithChildrenSample.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OpacityTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Draw.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-material/src/main/java/androidx/ui/material/surface/Surface.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
https://android-review.googlesource.com/1244127
Branch: androidx-master-dev
commit 9f229d7f8ccdc82186f5edbe158f6b8598c145a2
Author: Matvei Malkov <malkov@google.com>
Date: Wed Feb 26 14:06:29 2020
Deprecate Draw tag
This CL deprecates Draw tag, both versions: with and without the
children. All existing usages (tooling, repaintBoundaries, tests for
George to figure out) are supressing this error, corresponding bug are
filed. Deprecation message states that draw modifier or Canvas should be
used instead.
RelNote: Deprecated: Draw composable is a common source of bugs as it's
not a layout and takes parent size, but doesn't tell you that. Therefore, layout strategies, like Row
or Column doesn't work with Draw. You should use androidx.ui.core.draw modifier if you want to
decorate existent layout with custom drawing, use existent drawing modifiers (DrawBackground,
DrawBorder, PainterModifier) or use androidx.ui.foundation.Canvas to make a layout that takes space
and allows custom drawing.
Bug: 149827027
Test: tests should pass
Change-Id: I78392f01c2d37c2419812478d96417a1b8a1293d
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TableBorders.kt
M ui/ui-framework/api/0.1.0-dev06.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev06.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev06.txt
M ui/ui-framework/api/restricted_current.txt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawSample.kt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawWithChildrenSample.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OpacityTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Draw.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-material/src/main/java/androidx/ui/material/surface/Surface.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
Description