Fixed
Status Update
No update yet.
Comments
ma...@google.com
Thanks for the report!
ap...@google.com
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.
ap...@google.com
deleted
ap...@google.com
In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2e66e76f0f46827e98cbe712f353f91ce2209fe3
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 25 11:47:19 2020
Remove Draw tag usages in Text
As part of Draw tag removal, this CL removes Draw usages in text
selection logic. Rewrites Draw to draw modifier.
Bug: 149827027
Test: demos work fine + tests should pass
Change-Id: I4065a988b95848e9a0555b3365505a70b7299855
M ui/ui-framework/src/main/java/androidx/ui/core/Text.kt
M ui/ui-framework/src/main/java/androidx/ui/core/TextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/selection/SelectionHandles.kt
https://android-review.googlesource.com/1242993
Branch: androidx-master-dev
commit 2e66e76f0f46827e98cbe712f353f91ce2209fe3
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 25 11:47:19 2020
Remove Draw tag usages in Text
As part of Draw tag removal, this CL removes Draw usages in text
selection logic. Rewrites Draw to draw modifier.
Bug: 149827027
Test: demos work fine + tests should pass
Change-Id: I4065a988b95848e9a0555b3365505a70b7299855
M ui/ui-framework/src/main/java/androidx/ui/core/Text.kt
M ui/ui-framework/src/main/java/androidx/ui/core/TextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/selection/SelectionHandles.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9f229d7f8ccdc82186f5edbe158f6b8598c145a2
Author: Matvei Malkov <malkov@google.com>
Date: Wed Feb 26 14:06:29 2020
Deprecate Draw tag
This CL deprecates Draw tag, both versions: with and without the
children. All existing usages (tooling, repaintBoundaries, tests for
George to figure out) are supressing this error, corresponding bug are
filed. Deprecation message states that draw modifier or Canvas should be
used instead.
RelNote: Deprecated: Draw composable is a common source of bugs as it's
not a layout and takes parent size, but doesn't tell you that. Therefore, layout strategies, like Row
or Column doesn't work with Draw. You should use androidx.ui.core.draw modifier if you want to
decorate existent layout with custom drawing, use existent drawing modifiers (DrawBackground,
DrawBorder, PainterModifier) or use androidx.ui.foundation.Canvas to make a layout that takes space
and allows custom drawing.
Bug: 149827027
Test: tests should pass
Change-Id: I78392f01c2d37c2419812478d96417a1b8a1293d
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TableBorders.kt
M ui/ui-framework/api/0.1.0-dev06.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev06.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev06.txt
M ui/ui-framework/api/restricted_current.txt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawSample.kt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawWithChildrenSample.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OpacityTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Draw.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-material/src/main/java/androidx/ui/material/surface/Surface.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
https://android-review.googlesource.com/1244127
Branch: androidx-master-dev
commit 9f229d7f8ccdc82186f5edbe158f6b8598c145a2
Author: Matvei Malkov <malkov@google.com>
Date: Wed Feb 26 14:06:29 2020
Deprecate Draw tag
This CL deprecates Draw tag, both versions: with and without the
children. All existing usages (tooling, repaintBoundaries, tests for
George to figure out) are supressing this error, corresponding bug are
filed. Deprecation message states that draw modifier or Canvas should be
used instead.
RelNote: Deprecated: Draw composable is a common source of bugs as it's
not a layout and takes parent size, but doesn't tell you that. Therefore, layout strategies, like Row
or Column doesn't work with Draw. You should use androidx.ui.core.draw modifier if you want to
decorate existent layout with custom drawing, use existent drawing modifiers (DrawBackground,
DrawBorder, PainterModifier) or use androidx.ui.foundation.Canvas to make a layout that takes space
and allows custom drawing.
Bug: 149827027
Test: tests should pass
Change-Id: I78392f01c2d37c2419812478d96417a1b8a1293d
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TableBorders.kt
M ui/ui-framework/api/0.1.0-dev06.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev06.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev06.txt
M ui/ui-framework/api/restricted_current.txt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawSample.kt
D ui/ui-framework/integration-tests/samples/src/main/java/androidx/ui/framework/samples/DrawWithChildrenSample.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OpacityTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Draw.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-material/src/main/java/androidx/ui/material/surface/Surface.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
Description