lint UseRequireInsteadOfGet false positives [149891163]

Fixed

Bug

Status Update

No update yet.

Description

la...@gmail.com

created issue #1

Feb 20, 2020 10:36AM

Component used: Fragment
Version used: 1.2.2

The UseRequireInsteadOfGet lint checks in androidx-fragment 1.2.2 can detect false positives. Consider the following Java code in a Fragment:

View view = getSomeCompletelyUnrelatedView();
Objects.requireNonNull(view);

results in the following lint error:

Error: Use requireView() instead of Objects.requireNonNull(view) [UseRequireInsteadOfGet]

which would be valid if view was the result of a getView() call but it isn't.

Workaround: Rename the view variable to some other name

Comments

il...@google.com <il...@google.com> #2Feb 20, 2020 05:15PM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

la...@gmail.com <la...@gmail.com> #3Feb 20, 2020 09:27PM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

bug149891163.tgz

53 KB

Download

il...@google.com <il...@google.com> Feb 20, 2020 11:38PM

Assigned to ra...@google.com.

ap...@google.com <ap...@google.com> #4Feb 25, 2020 06:26PM

Marked as fixed.

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

il...@google.com <il...@google.com> #5Feb 25, 2020 06:48PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

an...@google.com <an...@google.com> #6Mar 10, 2020 11:51PM

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.

Issue 149891163