Fixed
Status Update
Comments
an...@google.com <an...@google.com> #2
there was a related discussion in b/150195079
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 0f072e5cb6523653474e7e9e1fa71180299b0821
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed May 06 15:07:11 2020
Introduce receiver scope for WithConstraints
This allows to simplify the usage as you will not need to write something like:
WithConstraints { constraints, _ -> }
When you need constraints, but not layout direction.
Plus allows us to provide additional helper properties minWidth, maxWidth, minHeight and maxHeight which are values in Dp instead of pixels. This simplifies the main usecase of the WithConstraints were you need to check if the available size in dp is within the threshold you have in Dp.
Relnote: WithConstraints trailing lambda API has been changed. Now instead of two params it has a receiver scope which in addition to constraints and layoutDirection provides minWidth, maxWidth, minHeight and maxHeight properties in Dp
Fixes: 149979702
Test: new tests
Change-Id: I91b9af740cd2613ddd4fe6d63cd539a46b52fc52
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/HotReloadIntegrationTests.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/realworld4/RealWorld4_Widgets.kt
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/core/WithConstraintsBenchmark.kt
M ui/ui-core/api/0.1.0-dev11.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev11.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/samples/src/main/java/androidx/ui/framework/samples/WithConstraintsSample.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M ui/ui-core/src/main/java/androidx/ui/core/Layout.kt
M ui/ui-layout/integration-tests/layout-demos/src/main/java/androidx/ui/layout/demos/RtlDemo.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AlignmentLineTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutSizeTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/RowColumnTest.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ColorPickerDemo.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
https://android-review.googlesource.com/1303637
Branch: androidx-master-dev
commit 0f072e5cb6523653474e7e9e1fa71180299b0821
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed May 06 15:07:11 2020
Introduce receiver scope for WithConstraints
This allows to simplify the usage as you will not need to write something like:
WithConstraints { constraints, _ -> }
When you need constraints, but not layout direction.
Plus allows us to provide additional helper properties minWidth, maxWidth, minHeight and maxHeight which are values in Dp instead of pixels. This simplifies the main usecase of the WithConstraints were you need to check if the available size in dp is within the threshold you have in Dp.
Relnote: WithConstraints trailing lambda API has been changed. Now instead of two params it has a receiver scope which in addition to constraints and layoutDirection provides minWidth, maxWidth, minHeight and maxHeight properties in Dp
Fixes: 149979702
Test: new tests
Change-Id: I91b9af740cd2613ddd4fe6d63cd539a46b52fc52
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/HotReloadIntegrationTests.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/realworld4/RealWorld4_Widgets.kt
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/core/WithConstraintsBenchmark.kt
M ui/ui-core/api/0.1.0-dev11.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev11.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/samples/src/main/java/androidx/ui/framework/samples/WithConstraintsSample.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M ui/ui-core/src/main/java/androidx/ui/core/Layout.kt
M ui/ui-layout/integration-tests/layout-demos/src/main/java/androidx/ui/layout/demos/RtlDemo.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AlignmentLineTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutSizeTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/RowColumnTest.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ColorPickerDemo.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
Description
Usually now they have to back-convert to dp from pixels as anything you're going to compose in that block speaks dp