Fixed
Status Update
No update yet.
Comments
cc...@google.com
BenchmarkState.pause/resumeTiming() both need to be renamed. Maybe pause/resumeMeasurement(), together with runWithMeasurementDisabled {}
cc...@google.com
Note - runWithTimingDisabled's block parameter should have been labelled crossinline. Let's fix that when we rename the API.
cc...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <
Link:
Deprecate runWithTimingDisabled in favor of runWithMeasurementDisabled
Expand for full commit details
Deprecate runWithTimingDisabled in favor of runWithMeasurementDisabled
Bug: 389149423
Fixes: 149979716
Test: Existing / presubmit
Opens up MicrobenchmarkScope since that's necessary to expose
runWithMeasurementDisabled properly. Inline functions of a restricted
superclass cannot be exposed by a subclass.
Relnote: "Deprecate runWithTimingDisabled in favor of runWithMeasurementDisabled, which more clearly describes the behavior - all metrics are paused. Additionally, expose the MicrobenchmarkScope superclass since redeclaring the runWithMeasurementDisabled function to open access isn't possible, since it's inline."
Change-Id: I9e23b0dfcff18f162ca0d2517734f3038870b59c
Files:
- M
benchmark/benchmark-common/api/current.txt - M
benchmark/benchmark-common/api/restricted_current.txt - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/Microbenchmark.kt - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/MicrobenchmarkPhase.kt - M
benchmark/benchmark-junit4/api/current.txt - M
benchmark/benchmark-junit4/api/restricted_current.txt - M
benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/BenchmarkRule.kt - M
benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/BenchmarkRuleLegacy.kt - M
benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/CpuEventCounterBenchmark.kt - M
benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoOverheadBenchmark.kt - M
benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoSdkOverheadBenchmark.kt - M
benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/SampleCustomBenchmark.kt - M
benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/SleepyBenchmark.kt - M
benchmark/samples/src/main/java/androidx/benchmark/samples/BenchmarkRuleSample.kt - M
compose/benchmark-utils/src/main/java/androidx/compose/testutils/benchmark/BenchmarkFirstExtensions.kt - M
compose/benchmark-utils/src/main/java/androidx/compose/testutils/benchmark/BenchmarksExtensions.kt - M
compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/ScrollerBenchmark.kt - M
compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/focusable/FocusableInLazyListBenchmark.kt - M
compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/lazy/LazyBenchmarkCommon.kt - M
compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/lazy/LazySwitchingStatesBenchmark.kt - M
compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/lazy/ReuseBenchmark.kt - M
compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/text/empirical/baselines/StaticLayoutBaseline.kt - M
compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/TrivialStartupBenchmark.kt - M
compose/material/material-ripple/benchmark/src/androidTest/java/androidx/compose/material/ripple/benchmark/RippleBenchmark.kt - M
compose/material/material/benchmark/src/androidTest/java/androidx/compose/material/benchmark/view/AndroidTextViewBenchmark.kt - M
compose/material3/benchmark/src/androidTest/java/androidx/compose/material3/benchmark/MaterialBenchmarkExtensions.kt - M
compose/runtime/runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/runtime/benchmark/ComposeBenchmarkBase.kt - M
compose/runtime/runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/runtime/benchmark/KotlinCoroutinesBenchmark.kt - M
compose/runtime/runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/runtime/benchmark/SnapshotStateObserverBenchmark.kt - M
compose/runtime/runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/runtime/benchmark/collection/MutableVectorBenchmark.kt - M
compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/FrameworkTextLayoutBenchmark.kt - M
compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/NonLinearFontScalingBenchmark.kt - M
compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphBenchmark.kt - M
compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/ParagraphWithLineHeightBenchmark.kt - M
compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/font/PlatformFontLookup.kt - M
compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/EditProcessorBenchmark.kt - M
compose/ui/ui-text/benchmark/src/androidTest/java/androidx/compose/ui/text/benchmark/input/GapBufferBenchmark.kt - M
compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/BenchmarkModifierExtensions.kt - M
compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/LifecycleAwareWindowRecomposerBenchmark.kt - M
compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/NestedScrollingBenchmark.kt - M
compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/accessibility/TextAccessibilityBenchmark.kt - M
compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/accessibility/TextFieldAccessibilityBenchmark.kt - M
compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/focus/ParameterizedFocusBenchmark.kt - M
compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/spatial/RectListBenchmark.kt - M
datastore/datastore-benchmark/src/androidTest/java/androidx/datastore/core/MultiProcessDataStoreTest.kt - M
datastore/datastore-benchmark/src/androidTest/java/androidx/datastore/core/SingleProcessDatastoreTest.kt - M
emoji2/emoji2-benchmark/src/androidTest/java/androidx/emoji2/benchmark/text/CachedEmojiCompatInitBenchmark.kt - M
emoji2/emoji2-benchmark/src/androidTest/java/androidx/emoji2/benchmark/text/EmojiProcessBenchmark.kt - M
profileinstaller/profileinstaller-benchmark/src/androidTest/java/androidx/profileinstaller/benchmark/ProfileInstallerTranscodeBenchmark.kt - M
room/benchmark/src/androidTest/java/androidx/room/benchmark/AmbiguousColumnResolverBenchmark.kt - M
wear/compose/compose-foundation/benchmark/src/androidTest/java/androidx/wear/compose/foundation/benchmark/ScalingLazyColumnBenchmark.kt - M
wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/PositionIndicatorBenchmark.kt - M
wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/SLCBasedBenchmarkHelper.kt - M
work/work-benchmark/src/androidTest/java/androidx/work/benchmark/InitializeBenchmark.kt
Hash: f95ae3f3d30cb7486c27a0857856dbfd15920c3a
Date: Wed Jan 22 16:04:15 2025
cc...@google.com
Note that we didn't mark the block as crossinline since it breaks a few reasonable patterns like this, where a caller passes a (non-crossinline) inline function:
We didn't see a good reason to restrict the inline function to local returns.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-common:1.4.0-alpha08androidx.benchmark:benchmark-junit4:1.4.0-alpha08
Description
We are adding the ability to capture new kinds of data with the benchmarking library, currently allocated memory.
This suggests a change to the name of the method runWithTimingDisabled. That method will be replaced with an equivalent method with a new name, and deprecated (but not removed yet).
There may be some similar API changes.