With the addition of memory benchmarking, rename some API [149979716]

Fixed

Bug

Status Update

No update yet.

Description

ow...@google.com

created issue #1

Feb 21, 2020 12:12PM

We are adding the ability to capture new kinds of data with the benchmarking library, currently allocated memory.

This suggests a change to the name of the method runWithTimingDisabled. That method will be replaced with an equivalent method with a new name, and deprecated (but not removed yet).

There may be some similar API changes.

Comments

cc...@google.com <cc...@google.com> #2Feb 21, 2020 05:04PM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

cc...@google.com <cc...@google.com> #3Apr 13, 2020 07:52PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

cc...@google.com <cc...@google.com> Jan 23, 2025 12:11AM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #4Jan 28, 2025 06:41PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

cc...@google.com <cc...@google.com> #5Jan 28, 2025 06:55PM

Note that we didn't mark the block as crossinline since it breaks a few reasonable patterns like this, where a caller passes a (non-crossinline) inline function: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:profileinstaller/profileinstaller-benchmark/src/androidTest/java/androidx/profileinstaller/benchmark/ProfileInstallerTranscodeBenchmark.kt;l=57;drc=f95ae3f3d30cb7486c27a0857856dbfd15920c3a

We didn't see a good reason to restrict the inline function to local returns.

pr...@google.com <pr...@google.com> #6Feb 12, 2025 06:40PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.4.0-alpha08
androidx.benchmark:benchmark-junit4:1.4.0-alpha08

Issue 149979716