Fixed
Status Update
No update yet.
Comments
so...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes:
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
https://android-review.googlesource.com/3046833
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes:
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
an...@google.com
Yes, current workaround is to wrap Row into another layout - Box, for example. The long term solution will be Ripple reimplemented as a Modifier when it will be possible
vi...@gmail.com
Okay, yeah that's the current workaround.
Description
Version of Gradle Plugin: 4.0.0-alpha09
Version of Gradle: 6.1
Version of Java: 1.8
OS: Android
Steps to Reproduce:
1. Update compose to dev-05 version
2. Padding component is missing, in favor of LayoutPadding
3. Replace Padding with LayoutPadding
Previous Code:
Ripple(bounded = true) {
Padding(padding = dimensionResource(id = R.dimen.padding)) {
Row {
restaurantImage(url = item.imageUrl)
Column(
modifier = LayoutFlexible(1f)
.plus(
LayoutPadding(
left = dimensionResource(id = R.dimen.padding),
right = dimensionResource(id = R.dimen.padding)
)
).plus(
LayoutGravity.Center
)
) {
restaurantInfo(item = item)
}
}
}
}
New Code:
Replace Padding with LayoutPadding as a modifier in Row.
P.S: Notice the ripple height and width in first vs second. First one takes draws ripple with padding into consideration and the second one doesn't. Though layout drawing similarly.