Fixed
Status Update
Comments
so...@google.com <so...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
an...@google.com <an...@google.com> #3
Yes, current workaround is to wrap Row into another layout - Box, for example. The long term solution will be Ripple reimplemented as a Modifier when it will be possible
vi...@gmail.com <vi...@gmail.com> #4
Okay, yeah that's the current workaround.
Description
Version of Gradle Plugin: 4.0.0-alpha09
Version of Gradle: 6.1
Version of Java: 1.8
OS: Android
Steps to Reproduce:
1. Update compose to dev-05 version
2. Padding component is missing, in favor of LayoutPadding
3. Replace Padding with LayoutPadding
Previous Code:
Ripple(bounded = true) {
Padding(padding = dimensionResource(id = R.dimen.padding)) {
Row {
restaurantImage(url = item.imageUrl)
Column(
modifier = LayoutFlexible(1f)
.plus(
LayoutPadding(
left = dimensionResource(id = R.dimen.padding),
right = dimensionResource(id = R.dimen.padding)
)
).plus(
LayoutGravity.Center
)
) {
restaurantInfo(item = item)
}
}
}
}
New Code:
Replace Padding with LayoutPadding as a modifier in Row.
P.S: Notice the ripple height and width in first vs second. First one takes draws ripple with padding into consideration and the second one doesn't. Though layout drawing similarly.