Fixed
Status Update
Comments
ra...@google.com <ra...@google.com>
ra...@google.com <ra...@google.com> #2
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4cd810e1a853a2e0c8946573be343615a6a7e53e
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Feb 25 12:26:31 2020
Deprecate setProgress(...) and replace with setCompletableProgress(...)
* Add a lint rule which flags uses of setProgress() and adds an
automatic lint-fix to setCompletableProgress().
Fixes: b/150080946
Test: Added unit tests for the API and lint rules.
Change-Id: I3bc2b831f22b9222216ef08871c569c53fa9eeb1
A work/workmanager-lint/src/main/java/androidx/work/lint/RxWorkerSetProgressDetector.kt
M work/workmanager-lint/src/main/java/androidx/work/lint/WorkManagerIssueRegistry.kt
A work/workmanager-lint/src/test/java/androidx/work/lint/RxWorkerSetProgressDetectorTest.kt
M work/workmanager-lint/src/test/java/androidx/work/lint/Stubs.kt
M work/workmanager-rxjava2/api/2.4.0-alpha01.txt
M work/workmanager-rxjava2/api/current.txt
M work/workmanager-rxjava2/api/public_plus_experimental_2.4.0-alpha01.txt
M work/workmanager-rxjava2/api/public_plus_experimental_current.txt
M work/workmanager-rxjava2/api/restricted_2.4.0-alpha01.txt
M work/workmanager-rxjava2/api/restricted_current.txt
M work/workmanager-rxjava2/src/main/java/androidx/work/RxWorker.java
A work/workmanager-rxjava2/src/test/java/androidx/work/SetCompletableProgressTest.kt
A work/workmanager-rxjava2/src/test/java/androidx/work/TestRxWorker.kt
https://android-review.googlesource.com/1242665
Branch: androidx-master-dev
commit 4cd810e1a853a2e0c8946573be343615a6a7e53e
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Feb 25 12:26:31 2020
Deprecate setProgress(...) and replace with setCompletableProgress(...)
* Add a lint rule which flags uses of setProgress() and adds an
automatic lint-fix to setCompletableProgress().
Fixes:
Test: Added unit tests for the API and lint rules.
Change-Id: I3bc2b831f22b9222216ef08871c569c53fa9eeb1
A work/workmanager-lint/src/main/java/androidx/work/lint/RxWorkerSetProgressDetector.kt
M work/workmanager-lint/src/main/java/androidx/work/lint/WorkManagerIssueRegistry.kt
A work/workmanager-lint/src/test/java/androidx/work/lint/RxWorkerSetProgressDetectorTest.kt
M work/workmanager-lint/src/test/java/androidx/work/lint/Stubs.kt
M work/workmanager-rxjava2/api/2.4.0-alpha01.txt
M work/workmanager-rxjava2/api/current.txt
M work/workmanager-rxjava2/api/public_plus_experimental_2.4.0-alpha01.txt
M work/workmanager-rxjava2/api/public_plus_experimental_current.txt
M work/workmanager-rxjava2/api/restricted_2.4.0-alpha01.txt
M work/workmanager-rxjava2/api/restricted_current.txt
M work/workmanager-rxjava2/src/main/java/androidx/work/RxWorker.java
A work/workmanager-rxjava2/src/test/java/androidx/work/SetCompletableProgressTest.kt
A work/workmanager-rxjava2/src/test/java/androidx/work/TestRxWorker.kt
Description
Version used: 2.3.1
Devices/Android versions reproduced on: Any
Calling setProgress on RxWorker throws a NullPointerException, because Single.fromFuture cannot be called with a Future returning a null value.
A Completable seems more appropriate in this case