Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5403f68bee90ccd8e8ad6d5949b2ad6e57e06fd8
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 25 09:36:01 2020
Fix conditional keep for NavArgs classes
Use the <1> placeholder to only keep the
fromBundle() method from NavArgs classes that
are already kept (i.e., those covered by the
-if).
Test: tested in sample app
Fixes: 150213558
Change-Id: I8e09ae767f694d8eb9b0cf5562be8640fca9c432
M navigation/navigation-common-ktx/proguard-rules.pro
https://android-review.googlesource.com/1243690
Branch: androidx-master-dev
commit 5403f68bee90ccd8e8ad6d5949b2ad6e57e06fd8
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 25 09:36:01 2020
Fix conditional keep for NavArgs classes
Use the <1> placeholder to only keep the
fromBundle() method from NavArgs classes that
are already kept (i.e., those covered by the
-if).
Test: tested in sample app
Fixes: 150213558
Change-Id: I8e09ae767f694d8eb9b0cf5562be8640fca9c432
M navigation/navigation-common-ktx/proguard-rules.pro
Description
Component used: Navigation Version used: 2.2.0
Similar to b/149665169 , navigation-common-ktx incorrectly uses a conditional keep that ends up keeping all instances of NavArgs's
fromBundle()
methods, even if the NavArgs class wasn't supposed to be kept.It should be updated to use the
<1>
placeholder so that it only keeps NavArgs classes that are kept due to some other reason.