NavArgs Keep ProGuard is too broad [150213558]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Feb 25, 2020 05:42PM

Component used: Navigation Version used: 2.2.0

Similar to b/149665169, navigation-common-ktx incorrectly uses a conditional keep that ends up keeping all instances of NavArgs's fromBundle() methods, even if the NavArgs class wasn't supposed to be kept.

It should be updated to use the <1> placeholder so that it only keeps NavArgs classes that are kept due to some other reason.

Comments

ap...@google.com <ap...@google.com> #2Feb 25, 2020 06:33PM

Marked as fixed.

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

an...@google.com <an...@google.com> #3Apr 4, 2020 12:02AM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

Issue 150213558

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 25, 2020 06:33PM

an...@google.com <an...@google.com> #3Apr 4, 2020 12:02AM

Add comment

Issue metadata