Orientation locking opt-in/out in Draggable / StateDraggable [150289741]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Feb 26, 2020 04:19PM

We need to add default orientation lock to Draggable and allow people to opt-out

Comments

ma...@google.com <ma...@google.com> #2Mar 18, 2020 04:58PM

Reassigned to sh...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

cl...@google.com <cl...@google.com> #3Mar 30, 2020 03:59PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ma...@google.com <ma...@google.com> #4Mar 30, 2020 05:03PM

Yep, this issue is blocked by two other ones, they are open, therefore this remain open as I will need to add this to draggable/scrollable.

sh...@google.com <sh...@google.com> May 20, 2020 05:49PM

Accepted by sh...@google.com.

ap...@google.com <ap...@google.com> #5Jun 23, 2020 07:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ca62bbb46226871e60750ed1bc1408e1db88af31
Author: Shep Shapard <shepshapard@google.com>
Date: Fri May 15 16:20:52 2020

Implemention of scroll orientation locking.

This implements a first pass of scroll
orientation locking that is akin to the
logic found in Android.

It also introduces ScrollGestureDetector
which is the same as DragGestureDetector
except that it disambiguates with other
ScrollGestureDetectors so that a given
pointer is only ever used to drag in
one orientation or the other.

The api that does the orientation locking
itself is experimental (we want to improve
on it) so it is RequiresOptIn.

Bug: 150289741
Fixes: 147609848
Test: New tests added in this CL.
Test: ./gradlew ui:ui-core:test

Change-Id: Ia611c96733f9749d9cc52d5ffbaf29644caf2e73

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/api_lint.ignore
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/CoreDemos.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/gestures/DragScaleGestureDetectorDemo.kt
A ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/gestures/HorizontalScrollersInVerticalScrollerDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/gestures/NestedScrollingDemo.kt
A ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/gestures/ScrollGestureFilterDemo.kt
A ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/gestures/VerticalScrollerInDrawerLayoutDemo.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/gesture/DragSlopExceededGestureFilter.kt
A ui/ui-core/src/androidMain/kotlin/androidx/ui/core/gesture/ExperimentalPointerInput.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/gesture/RawDragGestureFilter.kt
A ui/ui-core/src/androidMain/kotlin/androidx/ui/core/gesture/ScrollGestureFilter.kt
A ui/ui-core/src/androidMain/kotlin/androidx/ui/core/gesture/scrollorientationlocking/ScrollOrientationLocker.kt
M ui/ui-core/src/test/kotlin/androidx/ui/core/gesture/DragSlopExceededGestureFilterTest.kt
M ui/ui-core/src/test/kotlin/androidx/ui/core/gesture/RawDragGestureFilterTest.kt
A ui/ui-core/src/test/kotlin/androidx/ui/core/gesture/scrollorientationlocking/ScrollOrientationLockerSetupTest.kt
A ui/ui-core/src/test/kotlin/androidx/ui/core/gesture/scrollorientationlocking/ScrollOrientationLockerTest.kt

https://android-review.googlesource.com/1318178

ap...@google.com <ap...@google.com> #6Jun 26, 2020 06:44PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dd84977bccbc5c13006057ab81af5f334e0653b2
Author: Shep Shapard <shepshapard@google.com>
Date: Tue Jun 23 15:33:05 2020

Updated Interactions to use ScrollGestureFilter

This means that all things that use scrollable
or draggable will prevent other things that use
scrollable or draggable from scrolling in the
other orientation.

Relnote: "Version 1 of scroll orientation locking is
implemented across Compose."

Fixes: 150289741
Test: ./gradlew ui:ui-foundation:connectedCheck
Test: ./gradlew ui:ui-material:connectedCheck

Change-Id: I1ce7ae095c2af931e040411458a47cbc73d29eae

M ui/ui-foundation/src/main/java/androidx/ui/foundation/gestures/Draggable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/gestures/Scrollable.kt

https://android-review.googlesource.com/1348343

Issue 150289741