Fixed
Status Update
Comments
mo...@google.com <mo...@google.com> #2
If a layout node is detached, it should automatically be requesting a relayout and that should trigger redrawing as well. Is that logic incorrect?
an...@google.com <an...@google.com> #3
I think there are could be some corner cases when it is not enough.
when some LayoutNode which draws being removed we want to invalidate the RepaintBoundary containing it.
instead we do parentLayoutNode.onRequestMeasure, which iterates through all the parents it affects and then calls or requestLayout or invalidateRepaintBoundary for this grandParent. In first case requestLayout will cause invalidation of out AndroidComposeView and in the second invalidateRepaintBoundary can be potentially happening on other RepaintBoundary which wraps our grandparent. So the RepaintBoundary wrapping our original LayoutNode can be left not being redrawn.
right?
when some LayoutNode which draws being removed we want to invalidate the RepaintBoundary containing it.
instead we do parentLayoutNode.onRequestMeasure, which iterates through all the parents it affects and then calls or requestLayout or invalidateRepaintBoundary for this grandParent. In first case requestLayout will cause invalidation of out AndroidComposeView and in the second invalidateRepaintBoundary can be potentially happening on other RepaintBoundary which wraps our grandparent. So the RepaintBoundary wrapping our original LayoutNode can be left not being redrawn.
right?
mo...@google.com <mo...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b0286ae80bb8901cc834a88d5fe66f55f4817de3
Author: George Mount <mount@google.com>
Date: Thu Feb 20 15:14:09 2020
Add support for a LayerModifier.
Fixes: 150774014
This is the first step of changing RepaintBoundaryNode
to use modifiers instead. The next step is to replace
all use of RepaintBoundaryNode.
Relnote: "Added LayerModifier, a modifier that allows
adding a RenderNode for a Layout. It allows setting
clipping, opacity, rotation, scaling, and shadows.
This will replace RepaintBoundary."
Test: ran AndroidLayoutDrawTest
Change-Id: I7100dfe7a795567a48c2d5b3094e3dbd47e0f9c7
M ui/ui-core/api/0.1.0-dev07.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev07.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/build.gradle
A ui/ui-core/integration-tests/samples/src/main/java/androidx/ui/core/samples/LayerModifierSamples.kt
A ui/ui-core/src/main/java/androidx/ui/core/DrawLayerModifier.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-geometry/api/0.1.0-dev07.txt
M ui/ui-geometry/api/current.txt
M ui/ui-geometry/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-geometry/api/public_plus_experimental_current.txt
M ui/ui-geometry/api/restricted_0.1.0-dev07.txt
M ui/ui-geometry/api/restricted_current.txt
M ui/ui-geometry/src/main/java/androidx/ui/geometry/RRect.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-platform/api/0.1.0-dev07.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev07.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ComponentNodes.kt
M ui/ui-platform/src/main/java/androidx/ui/core/LayoutNodeWrapper.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OutlineResolver.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OwnedLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/RenderNodeLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/ViewLayer.kt
https://android-review.googlesource.com/1242671
Branch: androidx-master-dev
commit b0286ae80bb8901cc834a88d5fe66f55f4817de3
Author: George Mount <mount@google.com>
Date: Thu Feb 20 15:14:09 2020
Add support for a LayerModifier.
Fixes: 150774014
This is the first step of changing RepaintBoundaryNode
to use modifiers instead. The next step is to replace
all use of RepaintBoundaryNode.
Relnote: "Added LayerModifier, a modifier that allows
adding a RenderNode for a Layout. It allows setting
clipping, opacity, rotation, scaling, and shadows.
This will replace RepaintBoundary."
Test: ran AndroidLayoutDrawTest
Change-Id: I7100dfe7a795567a48c2d5b3094e3dbd47e0f9c7
M ui/ui-core/api/0.1.0-dev07.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev07.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/build.gradle
A ui/ui-core/integration-tests/samples/src/main/java/androidx/ui/core/samples/LayerModifierSamples.kt
A ui/ui-core/src/main/java/androidx/ui/core/DrawLayerModifier.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-geometry/api/0.1.0-dev07.txt
M ui/ui-geometry/api/current.txt
M ui/ui-geometry/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-geometry/api/public_plus_experimental_current.txt
M ui/ui-geometry/api/restricted_0.1.0-dev07.txt
M ui/ui-geometry/api/restricted_current.txt
M ui/ui-geometry/src/main/java/androidx/ui/geometry/RRect.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-platform/api/0.1.0-dev07.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev07.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ComponentNodes.kt
M ui/ui-platform/src/main/java/androidx/ui/core/LayoutNodeWrapper.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OutlineResolver.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OwnedLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/RenderNodeLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/ViewLayer.kt
Description
As we moving towards modifiers looks like now LayoutNode.detach() should be calling this as well making sure the parent is invalidated when we remove from the tree LayoutNode which was drawing via DrawModifier as otherwise we can continue displaying this LayoutNode as it was not removed
WDYF?