LayoutNode.detach() should do more work [150774014]

Fixed

Bug

Status Update

No update yet.

Description

an...@google.com

created issue #1

Mar 4, 2020 05:24PM

Currently in DrawNode.detach() we call `owner?.onInvalidate(this)`
As we moving towards modifiers looks like now LayoutNode.detach() should be calling this as well making sure the parent is invalidated when we remove from the tree LayoutNode which was drawing via DrawModifier as otherwise we can continue displaying this LayoutNode as it was not removed
WDYF?

Comments

mo...@google.com <mo...@google.com> #2Mar 4, 2020 11:39PM

Reassigned to an...@google.com.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

an...@google.com <an...@google.com> #3Mar 5, 2020 11:28AM

Reassigned to mo...@google.com.

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

mo...@google.com <mo...@google.com> Mar 5, 2020 07:19PM

Accepted by mo...@google.com.

ap...@google.com <ap...@google.com> #4Mar 6, 2020 08:18PM

Marked as fixed.

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

Issue 150774014

Description

Issue summary

Comments

mo...@google.com <mo...@google.com> #2Mar 4, 2020 11:39PM

an...@google.com <an...@google.com> #3Mar 5, 2020 11:28AM

mo...@google.com <mo...@google.com> Mar 5, 2020 07:19PM

ap...@google.com <ap...@google.com> #4Mar 6, 2020 08:18PM

Add comment

Issue metadata