LayoutNode.detach() should do more work [150774014]

Fixed

Bug

Status Update

No update yet.

Description

an...@google.com

created issue #1

Mar 4, 2020 05:24PM

Currently in DrawNode.detach() we call `owner?.onInvalidate(this)`
As we moving towards modifiers looks like now LayoutNode.detach() should be calling this as well making sure the parent is invalidated when we remove from the tree LayoutNode which was drawing via DrawModifier as otherwise we can continue displaying this LayoutNode as it was not removed
WDYF?

Comments

mo...@google.com <mo...@google.com> #2Mar 4, 2020 11:39PM

Reassigned to an...@google.com.

Thanks for the report! We identified the issue and are looking at possible fixes.

an...@google.com <an...@google.com> #3Mar 5, 2020 11:28AM

Reassigned to mo...@google.com.

This is still happening with the latest compose 1.4.0-alpha06. Any ETA for a proper fix?

mo...@google.com <mo...@google.com> Mar 5, 2020 07:19PM

Accepted by mo...@google.com.

ap...@google.com <ap...@google.com> #4Mar 6, 2020 08:18PM

Marked as fixed.

Hi, 1.4.0-alpha06 did not include a fix for this. We are working on the fix and are aiming to include it in one of the next releases.

Issue 150774014

Description

Issue summary

Comments

mo...@google.com <mo...@google.com> #2Mar 4, 2020 11:39PM

an...@google.com <an...@google.com> #3Mar 5, 2020 11:28AM

mo...@google.com <mo...@google.com> Mar 5, 2020 07:19PM

ap...@google.com <ap...@google.com> #4Mar 6, 2020 08:18PM

Add comment

Issue metadata