LayoutNode.detach() should do more work [150774014]

Fixed

Bug

Status Update

No update yet.

Description

an...@google.com

created issue #1

Mar 4, 2020 05:24PM

Currently in DrawNode.detach() we call `owner?.onInvalidate(this)`
As we moving towards modifiers looks like now LayoutNode.detach() should be calling this as well making sure the parent is invalidated when we remove from the tree LayoutNode which was drawing via DrawModifier as otherwise we can continue displaying this LayoutNode as it was not removed
WDYF?

Comments

mo...@google.com <mo...@google.com> #2Mar 4, 2020 11:39PM

Reassigned to an...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

an...@google.com <an...@google.com> #3Mar 5, 2020 11:28AM

Reassigned to mo...@google.com.

Thanks for the report!

mo...@google.com <mo...@google.com> Mar 5, 2020 07:19PM

Accepted by mo...@google.com.

ap...@google.com <ap...@google.com> #4Mar 6, 2020 08:18PM

Marked as fixed.

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Issue 150774014

Description

Issue summary

Comments

mo...@google.com <mo...@google.com> #2Mar 4, 2020 11:39PM

an...@google.com <an...@google.com> #3Mar 5, 2020 11:28AM

mo...@google.com <mo...@google.com> Mar 5, 2020 07:19PM

ap...@google.com <ap...@google.com> #4Mar 6, 2020 08:18PM

Add comment

Issue metadata