Fixed

Bug

Status Update

No update yet.

Description

ni...@google.com

created issue #1

Mar 4, 2020 09:37PM

Please note: This component is for the CameraX API used in Jetpack. Please DO NOT file Pixel Camera issues here.

Please describe your issue and include details such as the version of CameraX you are using and any relevant logs related to your issue.

logcat) when you're experiencing the issue, preferably while

the camera is still active.

CAMERAX VERSION (ex - 1.0.0-beta01)

CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version) all os version

ANDROID OS BUILD NUMBER: (Settings > About > Build number) all builds

DEVICE NAME: (Nexus 5X, Samsung S6, etc) All devices, but visible in Nexus 5, Nexus 6P

DESCRIPTION: The ImageProxy returned by ImageCapture.OnImageCapturedCallback.onCaptureSuccess() has the incorrect rotation. The rotation value is mismatched with the exif of the JPEG buffer.

STEPS TO REPRODUCE:

Take picture with ImageCapture using OnImageCapturedCallback()
Check the value of the ImageProxy.getImageInfo().getRotationDegrees()

OBSERVED RESULTS: The ImageProxy returned by ImageCapture.OnImageCapturedCallback.onCaptureSuccess() has the incorrect rotation. The rotation value is mismatched with the exif of the JPEG buffer.

EXPECTED RESULTS: The ImageProxy returned by ImageCapture.OnImageCapturedCallback.onCaptureSuccess() has the same rotation value as the rotation in the JPEG buffer exif.

REPRODUCIBILITY: (5 of out 5, 1 out of 100, etc) 5 out of 5 ADDITIONAL INFORMATION:

CODE FRAGMENTS (this will help us troubleshoot your issues):

Comments

an...@photomath.com <an...@photomath.com> #2Mar 6, 2020 01:30PM

b/241974799 fixes #3, i.e. optimize for load once, query many

Perfetto trace shell processor now runs in http server mode.

an...@photomath.com <an...@photomath.com> #3Mar 10, 2020 11:09AM

Pulling back to 1.2 because there are many instances of external users blocked on this. Plan is to open up what we have as experimental in 1.2.

ma...@google.com <ma...@google.com> #4Mar 23, 2020 07:45AM

Project: platform/frameworks/support
Branch: androidx-main

commit 80d9e8a14fae3015890c6ada4d6f72131cfd0d39
Author: Chris Craik <ccraik@google.com>
Date: Mon Feb 20 10:06:57 2023

Public experimental API for TraceProcessor

Bug:219851406
Test: ./gradlew bench:b-m:cC
Test: PerfettoTraceProcessorTest
Test: PerfettoTraceProcessorBenchmark
Relnote: "Added public experimental API for PerfettoTraceProcessor to
enable parsing trace content. This is a step toward fully custom
metrics based on Perfetto trace data."

Change-Id: I2659e84e85281f62f77abb6806f9c00bc2442f56

M benchmark/benchmark-macro/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro/build.gradle
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PerfettoTraceRuleTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AndroidxTracingTraceTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AudioUnderrunQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/BatteryDischargeQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureSweepTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkTraceTest.kt
D benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PowerQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/RowTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/AudioUnderrunQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/BatteryDischargeQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
D benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PowerQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StringHelper.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/ExperimentalPerfettoTraceProcessorApi.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/QueryResultIterator.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/Row.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/Slice.kt
M benchmark/benchmark/build.gradle
M benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/PerfettoTraceProcessorBenchmark.kt

https://android-review.googlesource.com/2447462

er...@google.com <er...@google.com> #5Mar 23, 2020 06:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit a1afb0d256ee6bf1aafb0ffd2cd958ac09c1fadd
Author: Chris Craik <ccraik@google.com>
Date: Thu Mar 09 16:43:42 2023

Add Experimental TraceMetric for fully custom metrics from traces

Fixes: 219851406
Test: ./gradlew bench:b-m:cC
Relnote: "Added new experimental TraceMetric API for defining fully
custom metrics based on content of a Perfetto trace."

Along with opening up the metric, migrates Metric to more extensible
output types. This allows us to eventually add further per-submetric
customization (such as per-submetric strictness on presence in each
iteration, custom display in studio, etc.

Also now correctly propogates TraceProcessor errors (e.g. query syntax
errors) to Kotlin callers.

This change also removes the concept of timelineRange in metric
results / trace UiState, as it's no longer necessary after
optimizations to remove sleep()s at the beginning/end of trace
capture.

Change-Id: I4ce3147b5bd1a13ae6a500389abdae3df461cacd

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/UiState.kt
M benchmark/benchmark-macro/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro/build.gradle
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
D benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/IterationResult.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MetricResultExtensions.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/QueryResultIterator.kt

https://android-review.googlesource.com/2479937

ap...@google.com <ap...@google.com> #6Mar 24, 2020 01:24AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.2.0-alpha12

ni...@google.com <ni...@google.com> Mar 24, 2020 01:24AM

Marked as fixed.

sh...@gmail.com <sh...@gmail.com> #7Mar 14, 2022 08:13AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.2.0-alpha13
androidx.benchmark:benchmark-macro:1.2.0-alpha13

IssueTracker

Wrong rotation in ImageProxy

Status Update

Description

If at all possible, capture an Android logcat (https://developer.android.com/studio/command-line/logcat) when you're experiencing the issue, preferably while

the camera is still active.

Comments

an...@photomath.com <an...@photomath.com> #2Mar 6, 2020 01:30PM

an...@photomath.com <an...@photomath.com> #3Mar 10, 2020 11:09AM

ma...@google.com <ma...@google.com> #4Mar 23, 2020 07:45AM

er...@google.com <er...@google.com> #5Mar 23, 2020 06:20PM

ap...@google.com <ap...@google.com> #6Mar 24, 2020 01:24AM

ni...@google.com <ni...@google.com> Mar 24, 2020 01:24AM

sh...@gmail.com <sh...@gmail.com> #7Mar 14, 2022 08:13AM

Issue 150802561

Description

If at all possible, capture an Android logcat (https://developer.android.com/studio/command-line/logcat) when you're experiencing the issue, preferably while

the camera is still active.

Issue summary

Comments

an...@photomath.com <an...@photomath.com> #2Mar 6, 2020 01:30PM

an...@photomath.com <an...@photomath.com> #3Mar 10, 2020 11:09AM

ma...@google.com <ma...@google.com> #4Mar 23, 2020 07:45AM

er...@google.com <er...@google.com> #5Mar 23, 2020 06:20PM

ap...@google.com <ap...@google.com> #6Mar 24, 2020 01:24AM

ni...@google.com <ni...@google.com> Mar 24, 2020 01:24AM

sh...@gmail.com <sh...@gmail.com> #7Mar 14, 2022 08:13AM

Add comment

Issue metadata