Fixed
Status Update
No update yet.
Comments
an...@photomath.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
an...@photomath.com
Great! Thanks a lot, I'll look for the live updates soon!
ma...@google.com
Hi Franklin, do we have an ETA for this fix?
YouCam is testing out our Beta build and want to evaluate if they can schedule to integrate CameraX to production.
YouCam is testing out our Beta build and want to evaluate if they can schedule to integrate CameraX to production.
er...@google.com
Hi Max,
We're looking at this for the next release, but we'll see if this makes the next buildcut.
We're looking at this for the next release, but we'll see if this makes the next buildcut.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit dde3c1204b59379456d03c2281a31c8cc68d7e92
Author: Franklin Wu <nilknarfuw@google.com>
Date: Wed Mar 04 13:57:58 2020
Fix wrong rotation in ImageProxy
Updated the camera2.ImageCaptureTest.capturedImageHasCorrectCroppingSize
test to rotated the crop rect into final output coordinate space instead
of comparing the pre-rotated crop rects
Changes the ImageProxy resolution of the buffer in ImageProxy. This
means that for JPEG images which have been rotated in HAL they will not
have the resolution of the sensor
Made sure rewind is called before accessing the buffer in ImageSaver
Relnote: "Fixed the ImageInfo.getRotationDegrees() from the ImageProxy
produced by ImageCapture so that it matches the EXIF orientation
rotational value."
Bug:
Test: androidx.camera.camera2.ImageCaptureTest
manual test
Change-Id: Id4281f3a168b710eafef120ea9d12800a6d8d98d
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/ImageCaptureTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageUtil.java
M camera/camera-core/src/main/java/androidx/camera/core/SettableImageProxy.java
https://android-review.googlesource.com/1260928
Branch: androidx-master-dev
commit dde3c1204b59379456d03c2281a31c8cc68d7e92
Author: Franklin Wu <nilknarfuw@google.com>
Date: Wed Mar 04 13:57:58 2020
Fix wrong rotation in ImageProxy
Updated the camera2.ImageCaptureTest.capturedImageHasCorrectCroppingSize
test to rotated the crop rect into final output coordinate space instead
of comparing the pre-rotated crop rects
Changes the ImageProxy resolution of the buffer in ImageProxy. This
means that for JPEG images which have been rotated in HAL they will not
have the resolution of the sensor
Made sure rewind is called before accessing the buffer in ImageSaver
Relnote: "Fixed the ImageInfo.getRotationDegrees() from the ImageProxy
produced by ImageCapture so that it matches the EXIF orientation
rotational value."
Bug:
Test: androidx.camera.camera2.ImageCaptureTest
manual test
Change-Id: Id4281f3a168b710eafef120ea9d12800a6d8d98d
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/ImageCaptureTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageUtil.java
M camera/camera-core/src/main/java/androidx/camera/core/SettableImageProxy.java
Description
Please note: This component is for the CameraX API used in Jetpack. Please DO NOT file Pixel Camera issues here.
Please describe your issue and include details such as the version of CameraX you are using and any relevant logs related to your issue.
If at all possible, capture an Android logcat (https://developer.android.com/studio/command-line/logcat ) when you're experiencing the issue, preferably while
the camera is still active.
CAMERAX VERSION (ex - 1.0.0-beta01)
CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version) all os version
ANDROID OS BUILD NUMBER: (Settings > About > Build number) all builds
DEVICE NAME: (Nexus 5X, Samsung S6, etc) All devices, but visible in Nexus 5, Nexus 6P
DESCRIPTION: The ImageProxy returned by ImageCapture.OnImageCapturedCallback.onCaptureSuccess() has the incorrect rotation. The rotation value is mismatched with the exif of the JPEG buffer.
STEPS TO REPRODUCE:
OBSERVED RESULTS: The ImageProxy returned by ImageCapture.OnImageCapturedCallback.onCaptureSuccess() has the incorrect rotation. The rotation value is mismatched with the exif of the JPEG buffer.
EXPECTED RESULTS: The ImageProxy returned by ImageCapture.OnImageCapturedCallback.onCaptureSuccess() has the same rotation value as the rotation in the JPEG buffer exif.
REPRODUCIBILITY: (5 of out 5, 1 out of 100, etc) 5 out of 5 ADDITIONAL INFORMATION:
CODE FRAGMENTS (this will help us troubleshoot your issues):